public inbox for [email protected]
help / color / mirror / Atom feedFrom: Noah Misch <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Amul Sul <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
Date: Sat, 21 May 2022 21:54:27 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKGL1Oozj9CEH5uG67bdaJC+WJY9234uv68--H2xXGHSEhg@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CA+hUKGL1Oozj9CEH5uG67bdaJC+WJY9234uv68--H2xXGHSEhg@mail.gmail.com>
On Sun, May 22, 2022 at 04:24:16PM +1200, Thomas Munro wrote:
> On Sat, May 21, 2022 at 6:15 PM Noah Misch <[email protected]> wrote:
> > On Mon, Apr 25, 2022 at 10:05:08AM -0400, Tom Lane wrote:
> > > Alvaro Herrera <[email protected]> writes:
> > > > Hmm, so 027_stream_regress.pl is not prepared to deal with any unlogged
> > > > tables that may be left in the regression database (which is what my
> > > > spgist addition did). I first tried doing a TRUNCATE of the unlogged
> > > > table, but that doesn't work either, and it turns out that the
> > > > regression database does not have any UNLOGGED relations. Maybe that's
> > > > something we need to cater for, eventually, but for now dropping the
> > > > table suffices. I have pushed that.
> > >
> > > It does seem like the onus should be on 027_stream_regress.pl to
> > > deal with that, rather than restricting what the core tests can
> > > leave behind.
> >
> > Yeah. Using "pg_dumpall --no-unlogged-table-data", as attached, suffices.
>
> 'pg_dumpall', '-f', $outputdir . '/primary.dump',
> - '--no-sync', '-p', $node_primary->port
> + '--no-sync', '-p', $node_primary->port,
> + '--no-unlogged-table-data' # if unlogged, standby
> has schema only
>
> LGTM, except for the stray extra whitespace.
perltidy contributes the prior-line whitespace change.
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: tweak to a few index tests to hits ambuildempty() routine.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox