Date: Mon, 23 May 2022 09:37:35 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	=?utf-8?Q?Przemys=C5=82aw?= Sztoch <przemyslaw@sztoch.pl>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@postgresql.org
Subject: Re: Add --{no-,}bypassrls flags to createuser
Message-ID: <20220523163735.GA938919@nathanxps13>
References: <YmDdxXPVNR8Km0v/@paquier.xyz>
 <CA+TgmoYeZg5deFv+r-dDvWQLuSOiTNAUbcsx4kY2XhGSeGz7FA@mail.gmail.com>
 <CAKFQuwa7kaFmEMszAAkpy-RiYZjW4M3MGo4-EidExZbOAgwQkg@mail.gmail.com>
 <20220425201947.GA2935432@nathanxps13>
 <d2d771c6cf1ed0f59513eb01c0cc0c78@oss.nttdata.com>
 <a720383d-9bf2-fcb7-22fa-aeea114c86a5@sztoch.pl>
 <4975ec63b73cfe4034867e90edbe16f8@oss.nttdata.com>
 <20220520214519.GA832375@nathanxps13>
 <Yos37n9xGnax7uBg@paquier.xyz>
 <e2659356769a778308bd3e18732ceeb2@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e2659356769a778308bd3e18732ceeb2@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220523163735.GA938919%40nathanxps13>
Precedence: bulk

On Mon, May 23, 2022 at 11:55:43PM +0900, Shinya Kato wrote:
> On 2022-05-23 16:29, Michael Paquier wrote:
>> May I ask for the addition of tests when one specifies multiple
>> switches for --admin and --member?  This would check the code path
>> where you build a list of role names.  You could check fancier string
>> patterns, while on it, to look after the use of fmtId(), say with
>> role names that include whitespaces or such.
> 
> Thanks!
> I changed to the test that describes multiple "-m".
> It seems to be working without any problems, how about it?

Michael also requested a test for multiple -a switches and for fancier
string patterns.  Once that is taken care of, I think this can be marked as
ready-for-committer.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com