Date: Tue, 24 May 2022 10:09:10 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	=?utf-8?Q?Przemys=C5=82aw?= Sztoch <przemyslaw@sztoch.pl>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@postgresql.org
Subject: Re: Add --{no-,}bypassrls flags to createuser
Message-ID: <20220524170910.GA1190535@nathanxps13>
References: <20220425201947.GA2935432@nathanxps13>
 <d2d771c6cf1ed0f59513eb01c0cc0c78@oss.nttdata.com>
 <a720383d-9bf2-fcb7-22fa-aeea114c86a5@sztoch.pl>
 <4975ec63b73cfe4034867e90edbe16f8@oss.nttdata.com>
 <20220520214519.GA832375@nathanxps13>
 <Yos37n9xGnax7uBg@paquier.xyz>
 <e2659356769a778308bd3e18732ceeb2@oss.nttdata.com>
 <20220523163735.GA938919@nathanxps13>
 <Yow+PeCg1bwi63ay@paquier.xyz>
 <0738cb3a8a52e850dd17a0065f2d8e5b@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0738cb3a8a52e850dd17a0065f2d8e5b@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220524170910.GA1190535%40nathanxps13>
Precedence: bulk

On Tue, May 24, 2022 at 08:07:31PM +0900, Shinya Kato wrote:
> On 2022-05-24 11:09, Michael Paquier wrote:
>> On Mon, May 23, 2022 at 09:37:35AM -0700, Nathan Bossart wrote:
>> > Michael also requested a test for multiple -a switches and for fancier
>> > string patterns.  Once that is taken care of, I think this can be
>> > marked as
>> > ready-for-committer.
>> 
>> Looking at v7, this means to extend the tests to process lists for
>> --admin with more name patterns.  And while on it, we could do the
>> same for the existing command for --role, but this one is on me, being
>> overly-pedantic while looking at the patch :)
> 
> Thanks! I fixed it.

We're still missing some "fancier" string patterns in the tests, but we
might just be nitpicking at this point.

I noticed that the cfbot tests for this are failing for Windows.  I've
looked at the relevant logs a bit, and I'm not sure what is going on.  The
expected log messages are indeed missing, but I haven't found any clues for
why those test cases are skipped.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com