Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntcbE-00070E-R0 for pgsql-hackers@arkaria.postgresql.org; Tue, 24 May 2022 22:01:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ntcbD-0007gy-67 for pgsql-hackers@arkaria.postgresql.org; Tue, 24 May 2022 22:01:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntcbC-0007gp-QL for pgsql-hackers@lists.postgresql.org; Tue, 24 May 2022 22:01:54 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ntcbA-0000f2-5L for pgsql-hackers@postgresql.org; Tue, 24 May 2022 22:01:53 +0000 Received: by mail-pj1-x102d.google.com with SMTP id z11so8192243pjc.3 for ; Tue, 24 May 2022 15:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=NzqU9zFwx9MlRsSYuDs2CgO1GESn0Mh1sKbCl2fF044=; b=O/6ofQvbmiue53sL7R4njtJEtFo2EZexz2ix8/67zIGafHbYT//sl0LkhaZF+2mx9i O707o86XekdhPqiyICt0EYBNU/tsmCUrIq63aouXavqp7VT67CAsFnjL4SX4QNFL6ygy sC1EiQq928f7wd5nhh97Pa5bUW+lKWzElP0GF6zRel5dbxo49TMH068vY6gl8OmjK1OX sXmCM8fmDAzU77D+FFt31RyXH00onqWvdLzXxhCjQSL1fp2Pt5TuCVMyCOPL3EKEv4QR 64CztX21Ua58YiPCForUsCsAKsGcLILWNx2IxFXuyGzdfw6NoUq3l6Q0HzYgjjXWM3ME JgcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=NzqU9zFwx9MlRsSYuDs2CgO1GESn0Mh1sKbCl2fF044=; b=UEHq4a06jDMaIao3n7ccF2rTcpciEp6AGGDPUkpq13oGmp27JZwfjJVsmePz4K5PZM ICShZDLKeVdCRL88JtcVukdCo4y5JtxgCnoWo8aHqHF4Lk8QoSRC8Rs2StwCPkNVW5Iu +LuUMwANbQI3sDSRK7euth7WNA91Zui8MaqAxCAAj7ct7ydF5snAaKhOnEtcZnQbSd0k NLAvy5S9q6fUe243mMUxN/tA7Mav2R+L1VbeEWNF2NLZGDsez4dHk2jgqv7kxxpmcksW vcLS2gkYp7QpbBzm8ddOjimG4znKFxFCn1WStBOFWGCfiAlCPA5HJse7HdP9jTi3yNvB 0wiA== X-Gm-Message-State: AOAM5311oQvGYxmKPT3RrIwUV6pNycsavH76wrZMme9a6NLEksJIOFyA UQwi+in0Lltl0aYQdpM6U3AZNjnAPMY= X-Google-Smtp-Source: ABdhPJwZMhD22g1OohBev81vqGouURvjAo6WKxEdmP6FFA+xh13WFOzl9gRzLZPckL40byxwYv/Img== X-Received: by 2002:a17:903:246:b0:153:84fe:a9b0 with SMTP id j6-20020a170903024600b0015384fea9b0mr29353635plh.163.1653429710774; Tue, 24 May 2022 15:01:50 -0700 (PDT) Received: from nathanxps13 ([50.54.155.70]) by smtp.gmail.com with ESMTPSA id z29-20020aa7959d000000b005183434ec86sm9889099pfj.135.2022.05.24.15.01.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 15:01:50 -0700 (PDT) Date: Tue, 24 May 2022 15:01:47 -0700 From: Nathan Bossart To: pgsql-hackers@postgresql.org Subject: fix stats_fetch_consistency value in postgresql.conf.sample Message-ID: <20220524220147.GA1298892@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In postgresql.conf.sample, stats_fetch_consistency is set to "none," but the default appears to be "cache." Should these be consistent? I've attached a patch to change the entry in the sample. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com --AqsLC8rIMeq19msA Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="fix_sample.patch" diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index a5a6d14cd4..48ad80cf2e 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -619,7 +619,7 @@ #track_io_timing = off #track_wal_io_timing = off #track_functions = none # none, pl, all -#stats_fetch_consistency = none +#stats_fetch_consistency = cache # - Monitoring - --AqsLC8rIMeq19msA--