public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andres Freund <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Date: Tue, 24 May 2022 21:23:32 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <20220524220147.GA1298892@nathanxps13>
<[email protected]>
Hi,
On 2022-05-25 13:11:40 +0900, Kyotaro Horiguchi wrote:
> At Tue, 24 May 2022 15:01:47 -0700, Nathan Bossart <[email protected]> wrote in
> > In postgresql.conf.sample, stats_fetch_consistency is set to "none," but
> > the default appears to be "cache." Should these be consistent? I've
> > attached a patch to change the entry in the sample.
>
> Good catch:)
>
> The base C variable is inirtialized with none.
> The same GUC is intialized with "cache".
> The default valur for the GUC is "none" in the sample file.
>
> I think we set the same value to C variable. However, I wonder if it
> would be possible to reduce the burden of unifying the three inital
> values.
Yes, they should be the same. I think we ended up switching the default at
some point, and evidently I missed a step when doing so.
Will apply.
I wonder if we should make src/test/modules/test_misc/t/003_check_guc.pl
detect this kind of thing?
Greetings,
Andres Freund
view thread (42+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox