Date: Thu, 26 May 2022 16:27:53 +0900 (JST)
Message-Id: <20220526.162753.632795261813283794.horikyota.ntt@gmail.com>
To: pryzby@telsasoft.com
Cc: michael@paquier.xyz, andres@anarazel.de, nathandbossart@gmail.com,
 pgsql-hackers@postgresql.org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <20220526.130045.1582015671130082847.horikyota.ntt@gmail.com>
References: <20220526.111018.1043498429473068058.horikyota.ntt@gmail.com>
	<20220526022553.GV19626@telsasoft.com>
	<20220526.130045.1582015671130082847.horikyota.ntt@gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
 boundary="--Next_Part(Thu_May_26_16_27_53_2022_916)--"
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20220526.162753.632795261813283794.horikyota.ntt%40gmail.com>
Precedence: bulk

----Next_Part(Thu_May_26_16_27_53_2022_916)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

At Thu, 26 May 2022 13:00:45 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> At Wed, 25 May 2022 21:25:53 -0500, Justin Pryzby <pryzby@telsasoft.com> wrote in 
> > And I think these should be updated it postgresql.conf to use the same unit as
> > in current_setting().
> > 
> >  track_activity_query_size   | 1kB                                                                      | 1024
> >  wal_buffers                 | 4MB                                                                      | -1
> >  wal_receiver_timeout        | 1min                                                                     | 60s
> >  wal_sender_timeout          | 1min                                                                     | 60s
> 
> I'm not sure we should do so.  Rather I'd prefer 60s than 1min here.

It could be in SQL, but *I* prefer to use perl for this, since it
allows me to write a bit complex things (than simple string
comparison) simpler.

So the attached is a wip version of that

Numeric values are compared considering units. But does not require
the units of the both values to match.  Some variables are ignored by
an explicit instruction (ignored_parameters).  Some variables are
compared case-insensitively by an explicit instruction
(case_insensitive_params).  bool and enum are compared
case-insensitively automatically.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

----Next_Part(Thu_May_26_16_27_53_2022_916)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-Add-fileval-bootval-consistency-check-of-GUC-paramet.patch"