Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nu1fC-0002w3-5h for pgsql-hackers@arkaria.postgresql.org; Thu, 26 May 2022 00:47:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nu1fA-0003Ya-QU for pgsql-hackers@arkaria.postgresql.org; Thu, 26 May 2022 00:47:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nu1f9-0003YQ-R8 for pgsql-hackers@lists.postgresql.org; Thu, 26 May 2022 00:47:40 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nu1f6-00056u-VK for pgsql-hackers@postgresql.org; Thu, 26 May 2022 00:47:38 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 43EC43200987; Wed, 25 May 2022 20:47:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 25 May 2022 20:47:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1653526053; x=1653612453; bh=blJ3ZlGh1O cJ0sYU48YZYfpGSbs9quuSsR8G1Cuu9c4=; b=hutmzFMUpGLV1etqkpmRpDCixW trAKDYLNDzQrg+S7OK6sDh6p34CPAavIJoj5IRC5YzRlQn0MytqA3eqRPaC4CXYG BlUguAQCTYdwuuae0I/aNvUjgGZE2+2Askyt/HjQhrVUEbanpAR870/Z5h7qJ45C QY1/6UtMowm1rA0sxCQz3BAj2sDnz6rMgiU0nEz6vtZrjSQxN6mnr+SYk9mB3tbX Vbxw+VPS0pwlxEknz4M538P5/IZX1ELavYiIj+5He9FhrVLuChm30A0oVg9IOh0d RlRmQN+g+cQoVodBTFzkh+qQOg4p0wmx5QywmfI/LvFxCco1dowsRZkzEuWA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1653526053; x=1653612453; bh=blJ3ZlGh1OcJ0sYU48YZYfpGSbs9 quuSsR8G1Cuu9c4=; b=j0ASwUh41pxMyCCIolzBArDXt0GHHNyLB231Qpz5Njka /7GAVmSbOHHA2S8PrT/fk7rlju4XMIq2BcD2Ue8EtiiddcnlaqNpZYFr/pWCaklM gIBUqq7tisf7Z1UjTuVKPA7kqekoHwd5AeB928ltd6aHkJdKXVaSd4LlwxJBHzhS oxiYzoNzQd+xunRfv7DohviTVoRRBqrjKhlw2diCNjVkWmBfMWn/M5E5f/BoWOS7 8DQgw3lw5G32XzgUmqsvcsIL47Kg+MOPuIXPkK2MXeC0sq5cTK36PsDzK1CLcy0r DRFgK0FEibV+rW0iUPP34JU0OGNWsSqtuRViR+fCdQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeeigdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesthdtre dttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghn rghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepvdfffeevhfetveffgeeiteefhf dtvdffjeevhfeuteegleduheetveduieettddunecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 20:47:33 -0400 (EDT) Date: Wed, 25 May 2022 17:47:31 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-hackers@postgresql.org Subject: Re: [RFC] building postgres with meson Message-ID: <20220526004731.km2ykossewzramt3@alap3.anarazel.de> References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Tom, in the meson unconference session you'd spotted flex flags for psqlscanslash.l (I think) being "hardcoded". As far as I can tell that's largely just copied from the Makefile): src/backend/parser/Makefile:scan.c: FLEXFLAGS = -CF -p -p src/backend/utils/adt/Makefile:jsonpath_scan.c: FLEXFLAGS = -CF -p -p src/bin/psql/Makefile:psqlscanslash.c: FLEXFLAGS = -Cfe -p -p src/fe_utils/Makefile:psqlscan.c: FLEXFLAGS = -Cfe -p -p note that it's not even FLEXFLAGS += or such. I honestly don't know enough about the various flex flags to judge what a better approach would be? Looks like these flags are case specific? Perhaps we could group them, i.e. have centrally defined "do compress" "don't compress" flex flags? Greetings, Andres Freund