Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuFe1-0008R3-K8 for pgsql-hackers@arkaria.postgresql.org; Thu, 26 May 2022 15:43:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nuFdz-0007pL-Ku for pgsql-hackers@arkaria.postgresql.org; Thu, 26 May 2022 15:43:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nuFdz-0007pC-3n for pgsql-hackers@lists.postgresql.org; Thu, 26 May 2022 15:43:23 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nuFdr-0000PL-KB for pgsql-hackers@lists.postgresql.org; Thu, 26 May 2022 15:43:22 +0000 Received: by mail-io1-xd2a.google.com with SMTP id a10so1917725ioe.9 for ; Thu, 26 May 2022 08:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XoEDNMw4Gc3F9LyNQzc9Sl1hB1vD17wYLy6uncTquGE=; b=BFqPKSkswVa4yoOR+MYhMI0twZP8uFZ4CLszzTufXlTh8nObRbkMZIlh8NzFZxTN7E ZN0P6KdyWF4yZOWZ8ymjKjzzsva/4RJD0Y+nXt6f3GvauIp84eWa/0C8JvatZyUxDmRY 2H+F8F13SAgsK4+vBAtptX0j61LODCwzJxqOJtVtCc/LZRJsuWi/bgMJI3S7FKc7YN67 kx/VbRcy6fr3qadcrfF/gk6YNwzKCvnzEL2EBM0BJtOsXnKnlQazjUgZNTbnSIY3E6m+ uOlJYwaw/a2QG1L6Z2K6P70SgdpRu3MgqpjtMF/mLTSU9y0xpNAvBAxl1XAk04lMx4jp 5dEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XoEDNMw4Gc3F9LyNQzc9Sl1hB1vD17wYLy6uncTquGE=; b=8NqAkVv49j7F9aVW2iUEEmHOOsCGRfH5tEN26FjBU2ZF2REIHodsuyTdqvOBp876Xx swLCLJpzKx4uO9kUYFwLmROn1SrLt+gH8eMuk/avtrJE3QFOGsLfItO+WpVxdvNt760a U86uzZhHbnfjYR47sdSSSrZrsdqQe10FRjVh9EfIRhHLNGeWXZsAYMIUnZpVZagPpnsZ Habbtn5a6pCj7ANIo4D+7wI0NUWNeWGMZqWzIGnOODzwkZUz1KR+fRwpIlYCH0dFLTWP jSM8utrnnwZp0h6G0XWWuGFfxPoEqrplU7m+z15DKqN8QtpmwQceTH1bYYSwPFkelA3v tGWQ== X-Gm-Message-State: AOAM530kGG1S8Yv0iNKv1aqtRVUFgaPhvTr2vBXa8u2syTT1zBrLuMkB PZG/EM6WRWrPBqy7usWy8t/reVZ5+LUKuA== X-Google-Smtp-Source: ABdhPJy/fvQNBLlsVsAI5qhCmgbst2Zd4TpjIVPa0RKTAGrnU8s/u11UKtTwUCcNI+B2WkxvBA56oQ== X-Received: by 2002:a05:6602:3d2:b0:65d:c151:f29f with SMTP id g18-20020a05660203d200b0065dc151f29fmr17619016iov.28.1653579793436; Thu, 26 May 2022 08:43:13 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id i1-20020a02cc41000000b0032b3a78177csm483026jaq.64.2022.05.26.08.43.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 May 2022 08:43:13 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id DA5A48008F8; Thu, 26 May 2022 10:43:11 -0500 (CDT) Date: Thu, 26 May 2022 10:43:11 -0500 From: Justin Pryzby To: Michael Paquier Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Remove support for Visual Studio 2013 Message-ID: <20220526154311.GA19626@telsasoft.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Maybe consider removing this workaround? The original problem report indicated that it didn't affect later versions: src/backend/optimizer/path/costsize.c: /* This apparently-useless variable dodges a compiler bug in VS2013: */ I'm not sure if it's worth removing this one, though: src/port/strtof.c: * On Windows, there's a slightly different problem: VS2013 has a strtof()