public inbox for [email protected]  

help / color / mirror / Atom feed

From: Justin Pryzby <[email protected]>
To: Amit Kapila <[email protected]>
Cc: [email protected]
Cc: Alvaro Herrera <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: [email protected]
Cc: Tom Lane <[email protected]>
Subject: Re: bogus: logical replication rows/cols combinations
Date: Fri, 27 May 2022 00:53:31 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1JDuOb96naN7akLpXz6G2ZGnGyg73w5Xt8ncAhWNF5Giw@mail.gmail.com>
References: <CAA4eK1+UCfKUaf41H6zHS2qR4CZoVtZe64yx_T-JVPSb1pdw_w@mail.gmail.com>
	<[email protected]>
	<CAA4eK1KfL=ez5fKPB-0Nrgf7wiqN9bXP-YHHj2YH5utXAmjYug@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAA4eK1KrXS0js9S0YFQRh9Vf5kaVOyz=NqA=0vMHvF1kxUJVkA@mail.gmail.com>
	<OS0PR01MB5716AD7C0FE7386630BDBAAB94D79@OS0PR01MB5716.jpnprd01.prod.outlook.com>
	<CAA4eK1JDuOb96naN7akLpXz6G2ZGnGyg73w5Xt8ncAhWNF5Giw@mail.gmail.com>

On Fri, May 27, 2022 at 11:17:00AM +0530, Amit Kapila wrote:
> On Tue, May 24, 2022 at 11:03 AM [email protected] <[email protected]> wrote:
> >
> > On Friday, May 20, 2022 11:06 AM Amit Kapila <[email protected]> wrote:
> >
> > Thanks for pointing it out. Here is the new version patch which add this version check.
> 
> I have added/edited a few comments and ran pgindent. The attached
> looks good to me. I'll push this early next week unless there are more
> comments/suggestions.

A minor doc review.
Note that I also sent some doc comments at [email protected].

+      lists among publications in which case <command>ALTER PUBLICATION</command>
+      command will be successful but later the WalSender in publisher or the

COMMA in which

remove "command" ?

s/in publisher/on the publisher/

+   Subscription having several publications in which the same table has been
+   published with different column lists is not supported.

Either "Subscriptions having .. are not supported"; or,
"A subscription having .. is not supported".

view thread (63+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: bogus: logical replication rows/cols combinations
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox