Feedback-ID: id4a34324:Fastmail
Date: Tue, 31 May 2022 12:25:40 -0700
From: Andres Freund <andres@anarazel.de>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [RFC] building postgres with meson
Message-ID: <20220531192540.vvvgrwienjpoku2g@alap3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20220526004731.km2ykossewzramt3@alap3.anarazel.de>
 <2071393.1653529113@sss.pgh.pa.us>
 <20220526024159.d72mg3rvrlj7h5kv@alap3.anarazel.de>
 <2090591.1653533919@sss.pgh.pa.us>
 <CAJ7c6TOCOvPsOm5azM1cgxz8=tDcf9bWhjw0DoDp1G=X4ai3=w@mail.gmail.com>
 <20220528191442.5sdp7nalfa5rczrs@alap3.anarazel.de>
 <CAJ7c6TMgZ5_sQ9tmFeu1NZjcMD5PuoyGqJ2TyUV3ZethmEyi=w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAJ7c6TMgZ5_sQ9tmFeu1NZjcMD5PuoyGqJ2TyUV3ZethmEyi=w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220531192540.vvvgrwienjpoku2g%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-05-31 16:49:17 +0300, Aleksander Alekseev wrote:
> I tried the branch on GitHub on MacOS Monterey 12.3.1 and Ubuntu 20.04 LTS.
> I was going to test it against several third party extensions, but it looks like
> it is a bit early for this. On Ubuntu I got the following error:

What do those extensions use to build? Since the unconference I added some
rudimentary PGXS compatibility, but it's definitely not complete yet.


> ```
> ../src/include/parser/kwlist.h:332:25: error: ‘PARAMETER’ undeclared here (not
> in a function)
> 332 | PG_KEYWORD("parameter", PARAMETER, UNRESERVED_KEYWORD, BARE_LABEL)
> 
> ../src/interfaces/ecpg/preproc/keywords.c:32:55: note: in definition of macro
> ‘PG_KEYWORD’
> 32 | #define PG_KEYWORD(kwname, value, category, collabel) value,
> ```

Huh. I've not seen this before - could you provide a bit more detail about
what you did? CI isn't testing ubuntu, but it is testing Debian, so I'd expect
this to work.


> On MacOS I got multiple errors regarding LDAP:

Ah, yes. Sorry, that's an open issue that I need to fix. -Dldap=disabled for
the rescue.  There's some crazy ordering dependency in macos framework
headers. The ldap framework contains an "ldap.h" header that includes
"ldap.h". So if you end up with the framework on the include path, you get
endless recursion.

Greetings,

Andres Freund