Date: Wed, 1 Jun 2022 09:35:37 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: silence compiler warning in brin.c
Message-ID: <20220601163537.GA2331988@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="dDRMvlgZJXvWKvBx"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/20220601163537.GA2331988%40nathanxps13>
Precedence: bulk


--dDRMvlgZJXvWKvBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi hackers,

I'm seeing a compiler warning in brin.c with an older version of gcc.
Specifically, it seems worried that a variable might not be initialized.
AFAICT there is no real risk, so I've attached a small patch to silence the
warning.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--dDRMvlgZJXvWKvBx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="silence_compiler_warning.patch"

diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c
index 52f171772d..5b564f9507 100644
--- a/src/backend/access/brin/brin.c
+++ b/src/backend/access/brin/brin.c
@@ -1010,7 +1010,7 @@ brin_summarize_range(PG_FUNCTION_ARGS)
 	Relation	heapRel;
 	Oid			save_userid;
 	int			save_sec_context;
-	int			save_nestlevel;
+	int			save_nestlevel = -1;
 	double		numSummarized = 0;
 
 	if (RecoveryInProgress())

--dDRMvlgZJXvWKvBx--