Feedback-ID: id4a34324:Fastmail
Date: Thu, 2 Jun 2022 08:22:57 -0700
From: Andres Freund <andres@anarazel.de>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [RFC] building postgres with meson
Message-ID: <20220602152257.szbstfitf3lwdssp@alap3.anarazel.de>
References: <2071393.1653529113@sss.pgh.pa.us>
 <20220526024159.d72mg3rvrlj7h5kv@alap3.anarazel.de>
 <2090591.1653533919@sss.pgh.pa.us>
 <CAJ7c6TOCOvPsOm5azM1cgxz8=tDcf9bWhjw0DoDp1G=X4ai3=w@mail.gmail.com>
 <20220528191442.5sdp7nalfa5rczrs@alap3.anarazel.de>
 <CAJ7c6TMgZ5_sQ9tmFeu1NZjcMD5PuoyGqJ2TyUV3ZethmEyi=w@mail.gmail.com>
 <20220531192540.vvvgrwienjpoku2g@alap3.anarazel.de>
 <CAJ7c6TPpbwdD4TupMrvjk3o9iF8gcgZbq3q+qNGomB5qmMMGGw@mail.gmail.com>
 <20220601210528.ok3rzjxjhbquf2if@alap3.anarazel.de>
 <CAJ7c6TMu0xGZUR419LSQCk=w230Q4eRCxqFx50RRWjKpFz5SSA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAJ7c6TMu0xGZUR419LSQCk=w230Q4eRCxqFx50RRWjKpFz5SSA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220602152257.szbstfitf3lwdssp%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2022-06-02 15:34:23 +0300, Aleksander Alekseev wrote:
> Hi Andres,
> 
> > Cool. I think I pushed a fix/workaround for the issue now. Still can't decide
> > whether it's apple's or meson's fault.
> 
> Many thanks! The fix solved the problem, I can compile with -Dldap=enabled now.
> The code passes the tests too.

Cool.


> > I suspect the errors might be due to CC/CPPFLAGS/... not being defined. I can
> > try to make it output something roughly compatible with the old output, for
> > most of those I already started to compute values for the PGXS compat stuff I
> > was hacking on recently.
> 
> Yes, that could explain the problem. Just for the record, I get several errors
> regarding src/export.h in TimescaleDB code [1]:
> 

I think this is timescale's issue. Why are you defining / undefining
PGDLLEXPORT?

Part of the patch series is to use visibility attributes, and your #if
TS_EMPTY(PGDLLEXPORT) thing can't handle that.

Greetings,

Andres Freund