Date: Sat, 11 Jun 2022 09:41:37 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: andres@anarazel.de, michael@paquier.xyz, nathandbossart@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Message-ID: <20220611144137.GC29853@telsasoft.com>
References: <20220526.130045.1582015671130082847.horikyota.ntt@gmail.com>
 <20220526.162753.632795261813283794.horikyota.ntt@gmail.com>
 <20220528202245.lrjn3v2m5shzgbsq@alap3.anarazel.de>
 <20220530.172719.867839911471994005.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220530.172719.867839911471994005.horikyota.ntt@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220611144137.GC29853%40telsasoft.com>
Precedence: bulk

On Mon, May 30, 2022 at 05:27:19PM +0900, Kyotaro Horiguchi wrote:
> At Sat, 28 May 2022 13:22:45 -0700, Andres Freund <andres@anarazel.de> wrote in 
> > Hi,
> > 
> > On 2022-05-26 16:27:53 +0900, Kyotaro Horiguchi wrote:
> > > It could be in SQL, but *I* prefer to use perl for this, since it
> > > allows me to write a bit complex things (than simple string
> > > comparison) simpler.
> > 
> > I wonder if we shouldn't just expose a C function to do this, rather than
> > having a separate implementation in a tap test.
> 
> It was annoying that I needed to copy the unit-conversion stuff.  I
> did that in the attached.  parse_val() and check_val() and the duped
> data is removed.

Note that this gives:

guc.c:7573:9: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized]

with gcc version 9.2.1 20191008 (Ubuntu 9.2.1-9ubuntu2)

I wonder whether you'd consider renaming pg_normalize_config_value() to
pg_pretty_config_value() or similar.

-- 
Justin