Date: Tue, 14 Jun 2022 16:08:19 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>,
	Melanie Plageman <melanieplageman@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Daniel Gustafsson <daniel@yesql.se>
Subject: Re: ccache, MSVC, and meson
Message-ID: <20220614210819.GW29853@telsasoft.com>
References: <20220522232606.GZ19626@telsasoft.com>
 <20220524193059.n432rlzezckxr6x2@alap3.anarazel.de>
 <20220524195202.GK19626@telsasoft.com>
 <20220524203039.xyqjggtytsyizsbl@alap3.anarazel.de>
 <20220524221747.GM19626@telsasoft.com>
 <20220525044817.kczou2nkbtk46itj@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220525044817.kczou2nkbtk46itj@alap3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220614210819.GW29853%40telsasoft.com>
Precedence: bulk

On Tue, May 24, 2022 at 09:48:17PM -0700, Andres Freund wrote:
> Hi,
> 
> On 2022-05-24 17:17:47 -0500, Justin Pryzby wrote:
> > Also, /O2 cuts ~3 minutes off the test time on cirrus, which seems worth it,
> > except that it omits frame pointers, which probably breaks debuggability.
> 
> It likely also causes us to use the non-debug C runtime? Which IMO would be
> bad, it does detect quite a few problems that are otherwise hard to find.
> 
> 
> > And when I pass /Oy- to "avoid omitting" frame pointers, several tests crash...
> 
> Huh. Do you get a backtrace containing anything remotely meaningful?

I looked at this again.  The issue isn't caused by optimizations, but
(apparently) by an absence of options in "msbuild --buildtype plain".
Adding /MD or /MDd fixes the issue.

That's done in the existing build system here:

src/tools/msvc/MSBuildProject.pm:                       runtime => 'MultiThreadedDebugDLL'
src/tools/msvc/MSBuildProject.pm:                       runtime => 'MultiThreadedDLL'

https://cirrus-ci.com/task/4895613501308928

BTW: vcvarsall isn't needed in the "check_world" scripts.

-- 
Justin