Date: Wed, 15 Jun 2022 10:39:25 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Ian Lawrence Barwick <barwick@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities"
 description
Message-ID: <20220615173925.GB2154@nathanxps13>
References: <20220521185743.GA886636@nathanxps13>
 <YomLAynQiordq3lg@paquier.xyz>
 <20220522202608.GA892371@nathanxps13>
 <YorM9Kv4bFVBoCsI@paquier.xyz>
 <20220523164142.GB938919@nathanxps13>
 <Yo2qtFNyJUe1rgF5@paquier.xyz>
 <YpHiW29SrgaQdy6b@paquier.xyz>
 <20220528131031.GB1876050@nathanxps13>
 <YpQtIo+uAKS9h+EI@paquier.xyz>
 <CAB8KJ=hGVTnCEVfZZHu49mveOps8hYaBS+KuhXUTehV05sCRkA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAB8KJ=hGVTnCEVfZZHu49mveOps8hYaBS+KuhXUTehV05sCRkA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220615173925.GB2154%40nathanxps13>
Precedence: bulk

On Tue, Jun 07, 2022 at 10:08:21PM +0900, Ian Lawrence Barwick wrote:
> A little late to the party, but as an alternative suggestion for the last
> part:
> 
>   "... and users who either own the session being reported on, or who have
>   privileges of the role to which the session belongs,"
> 
> so the whole sentence would read:
> 
>   Note that even when enabled, this information is only visible to superusers,
>   roles with privileges of the pg_read_all_stats role, and users who either own
>   the session being reported on or who have privileges of the role to which the
>   session belongs, so it should not represent a security risk.

This seems clearer to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com