Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1pSs-0002SJ-76 for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jun 2022 13:23:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o1pSr-00051Z-2T for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Jun 2022 13:23:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1pSq-000519-KY for pgsql-hackers@lists.postgresql.org; Thu, 16 Jun 2022 13:23:12 +0000 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o1pSn-0000LE-Dn for pgsql-hackers@postgresql.org; Thu, 16 Jun 2022 13:23:11 +0000 Received: by mail-il1-x132.google.com with SMTP id h18so900097ilj.7 for ; Thu, 16 Jun 2022 06:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=NfI9zg50lU9lHrBIm0GC6SjWnynTqZqrzSh/1Nnk49A=; b=GBOOq+86xRd1ORhCn34gvuyL9lLjGIxbTDDy1McEJj5Y66ZPudC+em39Y47QRk/PJ/ hbkFiFv+uP0wgNhjXAzclNuNNWOEuNKFRs4Ch6wWFTURPLN1xzY1Od4j0kvD19eOYCo2 cNklUe0u3RNrtl53E/57etrZ8cZZQCeIskwwbEBeuKdCggJeVogAitEVhHAz7P3lwoPK UVdTFqEr5432oPaXJNIFFT9jiplGKGUoArqt+BivfnwlEUSzeU3jwx6QjpKrY8Z8S36J spswHwk9C0Bb/sDbVHaRddQ1jI9SvhYCwVCOQ35EUO8LL/75JN0H9yl11ts/Sl4zeRns eRxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NfI9zg50lU9lHrBIm0GC6SjWnynTqZqrzSh/1Nnk49A=; b=EJ27Z2LDx4mJu7jXOpl3E03YjTWlQ7pu3ZQx0VoED2F+bgzYMNxJOE0OsAyAU9fAxS 9PautWqi57kjXTSJ1pWY8i5x70qYdHj0emNSTsW42yBwJR8OxaU9LWaayDJrpr0nkqYT khPDpI+oU2yIWDaRckYV09FbapQ2vxGWpY3RBQXhmP2Lh6GmgzG6JWpp0WJds+FD58b9 fTQsvbj6gvKsBN3EYhxQIMnKnDJuoIq506J8Vk6EdPoBVhmAp01899Cftscqjm+5Q8Eg e4Zo7hpB4+oc8j9df4Lp+F+zTfGXdohwYWBSfbOc8oxyS80QSCyxrAOWq1MDvuAqSpPs GGPg== X-Gm-Message-State: AJIora9HKyANTfKowZbjJTgF8mkZuoNUn1F01y5ar/GdYLHfEIxBMY5O GMjwjmWqxht+mXVM1hkKp/U70Q== X-Google-Smtp-Source: AGRyM1vykPV3aeP+1RYOxBr/CgnRGaiEficu5fnsaw7dJOGpwkWIwXGxfo34yZeH+ytk2pfZ594yWQ== X-Received: by 2002:a05:6e02:156c:b0:2d1:5b77:98d0 with SMTP id k12-20020a056e02156c00b002d15b7798d0mr2855714ilu.53.1655385788434; Thu, 16 Jun 2022 06:23:08 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id s17-20020a02ad11000000b0032e36d3843fsm891548jan.19.2022.06.16.06.23.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jun 2022 06:23:07 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 20A8B800B00; Thu, 16 Jun 2022 08:23:07 -0500 (CDT) Date: Thu, 16 Jun 2022 08:23:07 -0500 From: Justin Pryzby To: Kyotaro Horiguchi Cc: michael@paquier.xyz, andres@anarazel.de, nathandbossart@gmail.com, pgsql-hackers@postgresql.org Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample Message-ID: <20220616132306.GD29853@telsasoft.com> References: <20220530.172719.867839911471994005.horikyota.ntt@gmail.com> <20220611144137.GC29853@telsasoft.com> <20220616.171946.472801583794269334.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220616.171946.472801583794269334.horikyota.ntt@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jun 16, 2022 at 05:19:46PM +0900, Kyotaro Horiguchi wrote: > At Sat, 11 Jun 2022 09:41:37 -0500, Justin Pryzby wrote in > > Note that this gives: > > > > guc.c:7573:9: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > Mmm. I don't have an idea where the 'dst' came from... Well, in your latest patch, you've renamed it. guc.c:7586:19: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized] 7586 | PG_RETURN_TEXT_P(cstring_to_text(result)); -- Justin