Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6mPY-0000tH-BX for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Jun 2022 05:08:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o6mPW-0001or-S2 for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Jun 2022 05:08:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6mPW-0001oh-Hb for pgsql-hackers@lists.postgresql.org; Thu, 30 Jun 2022 05:08:14 +0000 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o6mPT-0005mO-Ty for pgsql-hackers@postgresql.org; Thu, 30 Jun 2022 05:08:13 +0000 Received: by mail-qv1-xf2e.google.com with SMTP id u7so5719989qvm.4 for ; Wed, 29 Jun 2022 22:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bcvMJNOt68gHiJUfNAcmXLNxrKc3Q8pDwvGbNWUoczc=; b=QJ9V5IvJL3i3Mx7abtvR2mJk3txgU58RWUU0tjwPrSPfiniDt0TUiaROj8ihHCsSG5 URw+2Dqlq/umvyovNi8/ytXh6QkIARGcABNcDaJA5A+uFY8PXQMCHZvUaQPjvOALclia /rdLufGvXYZk5UGDpV85PaDxUgKnejZt33d9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bcvMJNOt68gHiJUfNAcmXLNxrKc3Q8pDwvGbNWUoczc=; b=mwghqp45nb97Icw0M4TzUN1VFUIAKEPFnfKJK2yNtyCwrYudTCvxgSAo2Cff5JJ0Dv Lf6MzQR+6bCDEwP+fK7tfowfsQZYSccioLzROpkjnetwuPLML+4rjMWcFthxgDrIHgfB ma0AKyU8tzJdj3vI+kxkSXuxiXGGNALA8SKj12YEpKYwiR0bqIBCD5gjij1AQUs7YbTL 6aThCiuiOrUQ754iy2dUgkcB+VIS97D/UCJaOZFDIA969Z6DsBBu8mjdQK1PznvUAOlf n6fFyWjx8/a0Bmh0vyM6bo0pJ7ICpaBOTTSB53ObUA7EpmTD26dxrVu4CW9X19xgYxzY 288A== X-Gm-Message-State: AJIora+EWkUSEofvv3Kua6t9Z2X8uEi4lZa9K4S4A4+WurE/X0k7XR3y JgIqagQpDA71fS2u1MSY0GRWw4DHNcLE+A== X-Google-Smtp-Source: AGRyM1skqjIfr9t9w1ZXokFFpeS6/dtIweUm8b+HxYNlLV+cpQUfdwokqOrYFzlbMuzt2yJqPR5kzA== X-Received: by 2002:ac8:7f49:0:b0:305:3392:6eb7 with SMTP id g9-20020ac87f49000000b0030533926eb7mr5960153qtk.84.1656565691038; Wed, 29 Jun 2022 22:08:11 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::2e]) by smtp.gmail.com with ESMTPSA id bm9-20020a05620a198900b006a73ad95d40sm14397246qkb.55.2022.06.29.22.08.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2022 22:08:10 -0700 (PDT) Date: Wed, 29 Jun 2022 22:08:08 -0700 From: Noah Misch To: Bruce Momjian Cc: PostgreSQL-development Subject: Re: First draft of the PG 15 release notes Message-ID: <20220630050808.GC2257984@rfd.leadboat.com> References: <20220628063719.GA2208244@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jun 28, 2022 at 04:35:45PM -0400, Bruce Momjian wrote: > On Mon, Jun 27, 2022 at 11:37:19PM -0700, Noah Misch wrote: > > On Tue, May 10, 2022 at 11:44:15AM -0400, Bruce Momjian wrote: > > > I have completed the first draft of the PG 15 release notes > > > > > > > > > > > > > > > > > Remove PUBLIC creation permission on the > > linkend="ddl-schemas-public">public schema > > > (Noah Misch) > > > > > > > > > > > > This is a change in the default for newly-created databases in > > > existing clusters and for new clusters; USAGE > > > > If you dump/reload an unmodified v14 template1 (as pg_dumpall and pg_upgrade > > do), your v15 template1 will have a v14 ACL on its public schema. At that > > point, the fate of "newly-created databases in existing clusters" depends on > > whether you clone template1 or template0. Does any of that detail belong > > here, or does the existing text suffice? > > I think it is very confusing to have template0 have one value and > template1 have a different one, but as I understand it template0 will > only be used for pg_dump comparison, and that will keep template1 with > the same permissions, so I guess it is okay. It's an emergent property of two decisions. In the interest of backward compatibility, I decided to have v15 pg_dump emit GRANT for the public schema even when the source is an unmodified v14- database. When that combines with the ancient decision that a pg_dumpall or pg_upgrade covers template1 but not template0, one gets the above consequences. I don't see a way to improve on this outcome. > > > permissions on the public schema has not > > > been changed. Databases restored from previous Postgres releases > > > will be restored with their current permissions. Users wishing > > > to have the old permissions on new objects will need to grant > > > > The phrase "old permissions on new objects" doesn't sound right to me, but I'm > > not sure why. I think you're aiming for the fact that this is just a default; > > one can still change the ACL to anything, including to the old default. If > > these notes are going to mention the old default like they do so far, I think > > they should also urge readers to understand > > https://www.postgresql.org/docs/devel/ddl-schemas.html#DDL-SCHEMAS-PATTERNS > > before returning to the old default. What do you think? > > Agreed, the new text is: > > Users wishing to have the former permissions will need to grant > CREATE permission for PUBLIC on > the public schema; this change can be made on > template1 to cause all new databases to have these > permissions. What do you think about the "should also urge readers ..." part of my message?