Date: Thu, 30 Jun 2022 04:55:36 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	David Rowley <david.rowley@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-hackers@lists.postgresql.org,
	"Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>
Subject: Re: doc phrase: "inheritance child"
Message-ID: <20220630095536.GT28130@telsasoft.com>
References: <20220525013248.GO19626@telsasoft.com>
 <CAGEoWWSp+21tf0R4jhQQNTQspVz5cgJbYatdO1gqyasipi0=AQ@mail.gmail.com>
 <CA+HiwqFaDCNDimk=ibRY-AHccr5TmwOUN-uWnRq--6Xyk0w1Kw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="lrZ03NoBR/3+SXJZ"
Content-Disposition: inline
In-Reply-To: 
 <CA+HiwqFaDCNDimk=ibRY-AHccr5TmwOUN-uWnRq--6Xyk0w1Kw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220630095536.GT28130%40telsasoft.com>
Precedence: bulk


--lrZ03NoBR/3+SXJZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 27, 2022 at 03:22:38PM +0900, Amit Langote wrote:
> On Wed, May 25, 2022 at 1:30 PM Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> wrote:
> >        <para>
> > -       If true, the stats include inheritance child columns, not just the
> > +       If true, the stats include child tables, not just the
> >
> > We are replacing columns with tables; is that intentional?
> >
> > Partitioned tables do not have their own stats, it's just aggregated partition stats.
> > ...
> > -       If true, the stats include inheritance child columns, not just the
> > +       If true, the stats include child childs, not just the
> >         values in the specified relation
> >        </para></entry>
> >       </row>
> > @@ -13152,7 +13152,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
> >         <structfield>inherited</structfield> <type>bool</type>
> >        </para>
> >        <para>
> > -       If true, this row includes inheritance child columns, not just the
> > +       If true, this row includes child tables, not just the
> >         values in the specified table
> >        </para></entry>
> >       </row>
> >
> > Replacing inheritance child "column" with "tables", is that intentional?
> 
> I was a bit confused by these too, though perhaps the original text is
> not as clear as it could be?  Would the following be a good rewrite:

I updated the language to say "values from".  Is this better ?

And rebased to include changes to 401f623c7.

BTW nobody complained about my "child child" typo.

-- 
Justin

--lrZ03NoBR/3+SXJZ
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-doc-avoid-saying-inheritence-when-it-applies-to-part.patch"

From ee0b60ba9c5d08aff49600866d7e8439d836579a Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Mon, 25 Apr 2022 14:59:12 -0500
Subject: [PATCH] doc: avoid saying "inheritence" when it applies to
 partitioned rels

This is almost the opposite of 0c06534bd, which removed references to
"partition" in favour of "child".
---
 doc/src/sgml/catalogs.sgml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 2e46ed7cc57..851ff959021 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -2140,7 +2140,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
        <structfield>relhassubclass</structfield> <type>bool</type>
       </para>
       <para>
-       True if table or index has (or once had) any inheritance children
+       True if table or index has (or once had) any inheritance children or partitions
       </para></entry>
      </row>
 
@@ -7311,7 +7311,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
   <para>
    Normally there is one entry, with <structfield>stainherit</structfield> =
    <literal>false</literal>, for each table column that has been analyzed.
-   If the table has inheritance children, a second entry with
+   If the table has inheritance children or partitions, a second entry with
    <structfield>stainherit</structfield> = <literal>true</literal> is also created.  This row
    represents the column's statistics over the inheritance tree, i.e.,
    statistics for the data you'd see with
@@ -7394,7 +7394,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
        <structfield>stainherit</structfield> <type>bool</type>
       </para>
       <para>
-       If true, the stats include inheritance child columns, not just the
+       If true, the stats include values from child tables, not just the
        values in the specified relation
       </para></entry>
      </row>
@@ -7666,7 +7666,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
   <para>
    Normally there is one entry, with <structfield>stxdinherit</structfield> =
    <literal>false</literal>, for each statistics object that has been analyzed.
-   If the table has inheritance children, a second entry with
+   If the table has inheritance children or partitions, a second entry with
    <structfield>stxdinherit</structfield> = <literal>true</literal> is also created.
    This row represents the statistics object over the inheritance tree, i.e.,
    statistics for the data you'd see with
@@ -7720,7 +7720,7 @@ SCRAM-SHA-256$<replaceable>&lt;iteration count&gt;</replaceable>:<replaceable>&l
        <structfield>stxdinherit</structfield> <type>bool</type>
       </para>
       <para>
-       If true, the stats include inheritance child columns, not just the
+       If true, the stats include values from child tables, not just the
        values in the specified relation
       </para></entry>
      </row>
@@ -13157,7 +13157,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
        <structfield>inherited</structfield> <type>bool</type>
       </para>
       <para>
-       If true, this row includes inheritance child columns, not just the
+       If true, this row includes values from child tables, not just the
        values in the specified table
       </para></entry>
      </row>
@@ -13419,7 +13419,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
        (references <link linkend="catalog-pg-statistic-ext-data"><structname>pg_statistic_ext_data</structname></link>.<structfield>stxdinherit</structfield>)
       </para>
       <para>
-       If true, the stats include inheritance child columns, not just the
+       If true, the stats include values from child tables, not just the
        values in the specified relation
       </para></entry>
      </row>
@@ -13611,7 +13611,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
        (references <link linkend="catalog-pg-statistic-ext-data"><structname>pg_statistic_ext_data</structname></link>.<structfield>stxdinherit</structfield>)
       </para>
       <para>
-       If true, the stats include inheritance child columns, not just the
+       If true, the stats include values from child tables, not just the
        values in the specified relation
       </para></entry>
      </row>
-- 
2.17.1


--lrZ03NoBR/3+SXJZ--