Feedback-ID: id4a34324:Fastmail
Date: Mon, 4 Jul 2022 19:40:11 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: TAP output format in pg_regress
Message-ID: <20220705024011.nsvsfdedvridfhgc@awork3.anarazel.de>
References: <BD4B107D-7E53-4794-ACBA-275BEB4327C9@yesql.se>
 <49A54862-C682-4B60-9155-05F178FA79DC@yesql.se>
 <20220321234924.kcc3q26o7sx6rnfa@alap3.anarazel.de>
 <E35C4A74-7265-4106-908E-5D3E5B9D8C2E@yesql.se>
 <489D2B5A-B26F-4918-BC07-B426329169E3@yesql.se>
 <5e6bc6a6-0a4e-109d-2b7d-c286dc58d609@enterprisedb.com>
 <461F8D8E-77D8-4F15-84C6-F7FD239018C0@yesql.se>
 <20220704225831.peh3a3afdgf6b5rj@awork3.anarazel.de>
 <1803389.1656986184@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1803389.1656986184@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220705024011.nsvsfdedvridfhgc%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-07-04 21:56:24 -0400, Tom Lane wrote:
> > For non-parallel tests I think we currently print the test name before running
> > the test, which obviously doesn't work well when needing to print the 'ok'
> > 'not ok' first.
> 
> Is this still a consideration?  We got rid of serial_schedule some
> time ago.

Not really for the main tests, there's a few serial steps, but not enough that
a bit additional output would be an issue. I think all tests in contrib are
serial though, and some have enough tests that it might be annoying?


> > I wonder if for parallel tests we should print the test number based on the
> > start of the test rather than the finish time?
> 
> I think we need the test number to be stable, so it had better be the
> ordering appearing in the schedule file.  But we already print the
> results in that order.

I remembered some asynchronizity, but apparently that's just the "parallel
group" line.

Greetings,

Andres Freund