Feedback-ID: id4a34324:Fastmail
Date: Tue, 5 Jul 2022 12:08:54 -0700
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
	David Rowley <dgrowleyml@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Nikita Glukhov <n.gluhov@postgrespro.ru>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to
 ExprEvalStep size
Message-ID: <20220705190854.azgdkzystb2dvzel@awork3.anarazel.de>
References: <20220617052228.mjwns6ugspihamsc@alap3.anarazel.de>
 <20220617062456.ahbwho67m7c3lnr3@alap3.anarazel.de>
 <1221363.1655476388@sss.pgh.pa.us>
 <20220617173055.oaqns4ty235vlyyw@alap3.anarazel.de>
 <20220617200605.3moq7dtxua5cxemv@alap3.anarazel.de>
 <018c0370-9e82-8b78-cd00-1fdea0c6811c@dunslane.net>
 <20220621212516.2rf4ys2sa7vingsi@alap3.anarazel.de>
 <4800a657-ebea-740c-5f2f-d5b096012a25@dunslane.net>
 <YrQYZEHoWspg6cki@paquier.xyz>
 <20220624015145.ipdljp22u55xc4rc@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220624015145.ipdljp22u55xc4rc@alap3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20220705190854.azgdkzystb2dvzel%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-06-23 18:51:45 -0700, Andres Freund wrote:
> > Waiting for beta3 would a better move at this stage.  Is somebody confident
> > enough in the patches proposed?
> 
> 0001 is the one that needs to most careful analysis, I think. 0002 I'd be fine
> with pushing after reviewing it again. For 0003 David's approach might be
> better or worse, it doesn't matter much I think. 0004 is ok I think, perhaps
> with the exception of quibbling over some naming decisions?

I don't quite feel comfortable with 0001, without review by others. So my
current plan is to drop it and use get_timeout_active() "manually". We can
improve this in HEAD to remove the redundancy.

I've pushed what was 0004, will push what was 0002 with the above change in a
short while unless somebody protests PDQ. Then will look at David's edition of
my 0003.

Greetings,

Andres Freund