Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8oh4-0008Px-4r for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jul 2022 19:58:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8oh2-0006Kf-Rn for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Jul 2022 19:58:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8oh2-0006Jp-Ie for pgsql-hackers@lists.postgresql.org; Tue, 05 Jul 2022 19:58:44 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8ogz-0001ZN-E2 for pgsql-hackers@lists.postgresql.org; Tue, 05 Jul 2022 19:58:43 +0000 Received: by mail-qk1-x729.google.com with SMTP id b24so9572073qkn.4 for ; Tue, 05 Jul 2022 12:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n3hZHBamwpjrOT/X1+0TajWW3/uIYQaePRmO1EWVt80=; b=V2fGYSdWHfOCKR+HW7QAGHG0m/t6sI0XJG2Hj8dMAUZel5uLCME8Sm5Ew8xii/Hbd+ zZzLuvre9iUqOULQcPIq3MlXvOHnsb3f2EyPL3SBsd2MdCQ5+eLwsaI8ElNx5pkPTNxh FEYUtY1SwlWZ56JzAWdnfPE4ZCKZNbeI3RHweIUsRKzotpDtG7h8Y+2M1wZomslXR3/L /rI4sJmxP9XA3nCEmF9rV6yKSqGjNasE4Fqi2KmC6bJq03kXfGPNFGzjLbcNfdBbs+QW 0SO9toS1cawzykuQ/zz2mxNxAEoTjb8pMlcokdZ8OWRGW4u4PObKbcNELlAnl+cr7bK9 Yn6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n3hZHBamwpjrOT/X1+0TajWW3/uIYQaePRmO1EWVt80=; b=i/vlI68pplbG87US9TFyrY9oTLrgf7ZUlLkPJBFaWfWKTo8s6dS3BkO7FedyDt+98R ts7Gt0W99pvdY6bIdnQ2/ZFqAL86rbVKYLVL41EJmiJnMXCVMmOkeZppbWx9g4mZdR4/ b9dR5ogegHDziUoLZ6qkIApO2rNNfn03loffyy1rhnBpUaQJvF8GBV7euOH+nHJFDOsN ouIDt+ZXvWGpINLCqBOhyO2k8FfJ/O6mFamnhALOL+7I8OeGINZin1O7aVNPDXW2q86n dbOVaFHcrllVOW1Cn7JR+OccEqvEvIbv2B7iAQX8ll7fqgM7eWfuXVjqju7EJD+mggdX fuOA== X-Gm-Message-State: AJIora9VoTnY1K86o9c9vsJGkCsi16FCYGzxxF1Unl/Se1o689duTTHy V0jEjwF9EPq03CoU2iLSlcRyoA== X-Google-Smtp-Source: AGRyM1sfkpUN7GlV02ahKTeOta/aPp6n867qLKwwqqom4qJ/Mwp7pPcfy4U8CSgnKX1DaIrq36dskQ== X-Received: by 2002:a05:620a:25c8:b0:6ae:2408:6e9a with SMTP id y8-20020a05620a25c800b006ae24086e9amr25125849qko.222.1657051120053; Tue, 05 Jul 2022 12:58:40 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id o1-20020a05620a2a0100b006a6f68c8a87sm20317354qkp.126.2022.07.05.12.58.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jul 2022 12:58:39 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id DB8B0800760; Tue, 5 Jul 2022 14:58:38 -0500 (CDT) Date: Tue, 5 Jul 2022 14:58:38 -0500 From: Justin Pryzby To: Alvaro Herrera Cc: Jaime Casanova , Roberto Mello , pgsql-hackers@lists.postgresql.org Subject: Re: doc: BRIN indexes and autosummarize Message-ID: <20220705195838.GT13040@telsasoft.com> References: <20220704212227.GN13040@telsasoft.com> <20220705114727.ryirrnks7rijhdh3@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220705114727.ryirrnks7rijhdh3@alvherre.pgsql> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jul 05, 2022 at 01:47:27PM +0200, Alvaro Herrera wrote: > OK, I have adopted all your proposed changes, thanks for submitting in > both forms. I did some more wordsmithing and pushed, to branches 12 and > up. 11 fails 'make check', I think for lack of Docbook id tags, and I > didn't want to waste more time. Kindly re-read the result and let me > know if I left something unaddressed, or made something worse. The > updated text is already visible in the website: > https://www.postgresql.org/docs/devel/brin-intro.html One issue: + summarized range, the range that the new page belongs into + does not automatically acquire a summary tuple; "belongs into" sounds wrong - "belongs to" is better. I'll put that change into my "typos" branch to fix later if it's not addressed in this thread. -- Justin