Date: Thu, 7 Jul 2022 11:22:51 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: remove more archiving overhead
Message-ID: <20220707182251.GA2255242@nathanxps13>
References: <20220222173711.GA3852671@nathanxps13>
 <20220222195229.GA42988@nathanxps13>
 <20220224.141349.1809640551882183816.horikyota.ntt@gmail.com>
 <20220224175553.GA660690@nathanxps13>
 <20220407222327.GA1363808@nathanxps13>
 <768e6cb3-256d-9c0b-1797-62420ffca7ae@oss.nttdata.com>
 <CA+TgmoaeTe4oUT39A4nt=8LD6UJ5u0vcmGc5+Aksn-4oKRb8-w@mail.gmail.com>
 <17147b74-5465-9a7a-ae27-305d1200482c@pgmasters.net>
 <20220707161825.GA2205004@nathanxps13>
 <20220707175142.GA2254092@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220707175142.GA2254092@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20220707182251.GA2255242%40nathanxps13>
Precedence: bulk

On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
> +    library to ensure that it indeed does not overwrite an existing file.  When
> +    a pre-existing file is encountered, the archive library may return
> +    <literal>true</literal> if the WAL file has identical contents to the
> +    pre-existing archive.  Alternatively, the archive library can return

This should likely say something about ensuring the pre-existing file is
persisted to disk before returning true.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com