Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAel4-00086X-3i for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Jul 2022 21:46:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oAel2-0002xX-MF for pgsql-hackers@arkaria.postgresql.org; Sun, 10 Jul 2022 21:46:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAel2-0002xO-DH for pgsql-hackers@lists.postgresql.org; Sun, 10 Jul 2022 21:46:28 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAel0-000869-3a for pgsql-hackers@postgresql.org; Sun, 10 Jul 2022 21:46:27 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2BF775C0108; Sun, 10 Jul 2022 17:46:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 10 Jul 2022 17:46:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1657489584; x=1657575984; bh=5jjTDbmj09 jeQLwUG/JbGZJoaXe/BM8mgaCwOJ3sLh4=; b=Kx6Lv2fmcvCSbMLYUsJVn4C/gf af2rhSYWRznJieWhzU09LqI6rs5JW7eBb7IN04WcTjgcFQfK3aiG7Lkl8KrtgYxT 7AJha7PPN19ZZ5F1QKOaO0xNsBiard4tQzFdLRwvztNrkwb/0YkYizu6b6KQ7NZu jRJHDsWmCiX4Op9BZtWsJCrflUipEazHvXBySOm87zyAY5woqQuIlecLYk0ESJOA RWBDnQ5Jj0lI+6IUM0X7x/GhXt7c4641BBx0ShtEqCExZg1y0Cbrm9H4A5/Au6RZ LcDxtw1xuLX8iu32vXSsugC0LnXjJakffLIddjb1lXTqRMbbZ7WniqrY7ZIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657489584; x=1657575984; bh=5jjTDbmj09jeQLwUG/JbGZJoaXe/ BM8mgaCwOJ3sLh4=; b=eydG9AavWhHrh0GnOXd9EjUGFBEXH7SKEDU62k3eZfdE /aOrrU7cOEpiUYI053z1G1GUNcfgjbyVbcIlgglHdPRDUKPSDBfmjSdzODp0YRsc 1EeOLjFPS8KRXJE8WVhc7683kTuEkOIeCx+cE7MGQJR60iUOuM0S+5qeLg6B6RZM U2Eo5Cq49i+NGiTTurKkHsI2X5quaanrAxfIQIKs4mRetKAv2+op0IAV/+Q0t/F0 VsmQ1ErlEphymIBjf0T4lpXRZM08Af1qBKibgaJh5Bi1H5TuD1IsctSsqgJgWvFB d6T6wT6d1ROCw05qdQC39OFEktf+6+6IjJH9eVX/ew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejvddgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Jul 2022 17:46:23 -0400 (EDT) Date: Sun, 10 Jul 2022 14:46:22 -0700 From: Andres Freund To: Peter Eisentraut Cc: Tom Lane , David Rowley , pgsql-hackers Subject: Re: automatically generating node support functions Message-ID: <20220710214622.haiektrjzisob6rl@awork3.anarazel.de> References: <1294462.1656875649@sss.pgh.pa.us> <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com> <1593978.1656953960@sss.pgh.pa.us> <2592455.1657140387@sss.pgh.pa.us> <3302658.1657288366@sss.pgh.pa.us> <611d2e! 93-6330-47fa-0970-72316aed50f2@enterprisedb.com> <3488143.1657310625@sss.pgh.pa.us> <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2022-07-09 16:37:22 +0200, Peter Eisentraut wrote: > On 08.07.22 22:03, Tom Lane wrote: > > I think this is ready to go (don't forget the catversion bump). > > This is done now, after a brief vpath-shaped scare from the buildfarm > earlier today. I was just rebasing meson ontop of this and was wondering whether the input filenames were in a particular order: node_headers = \ nodes/nodes.h \ nodes/execnodes.h \ nodes/plannodes.h \ nodes/primnodes.h \ nodes/pathnodes.h \ nodes/extensible.h \ nodes/parsenodes.h \ nodes/replnodes.h \ nodes/value.h \ commands/trigger.h \ commands/event_trigger.h \ foreign/fdwapi.h \ access/amapi.h \ access/tableam.h \ access/tsmapi.h \ utils/rel.h \ nodes/supportnodes.h \ executor/tuptable.h \ nodes/lockoptions.h \ access/sdir.h Can we either order them alphabetically or add a comment explaining the order? - Andres