Feedback-ID: id4a34324:Fastmail
Date: Mon, 11 Jul 2022 09:14:04 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	David Rowley <dgrowleyml@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
Message-ID: <20220711161404.qxq5lwbuzeg63xce@awork3.anarazel.de>
References: <b9acf63c-6693-d87c-f010-ca8ad502a39f@enterp! risedb.com>
 <3302658.1657288366@sss.pgh.pa.us>
 <611d2e! 93-6330-47fa-0970-72316aed50f2@enterprisedb.com>
 <3488143.1657310625@sss.pgh.pa.us>
 <11148777-fbe2-5188-195d-48f5083573c5@enterprisedb.com>
 <20220710214622.haiektrjzisob6rl@awork3.anarazel.de>
 <815831.1657494597@sss.pgh.pa.us>
 <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com>
 <1079552.1657549379@sss.pgh.pa.us>
 <1123940.1657555629@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1123940.1657555629@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220711161404.qxq5lwbuzeg63xce%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-07-11 12:07:09 -0400, Tom Lane wrote:
> I wrote:
> > Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> >> could not handle type "ScanDirection" in struct "IndexScan" field
> >> "indexorderdir"
>
> > Ah, I see.  Still, we could also handle that with
> > push @enum_types, qw(ScanDirection);
>
> I tried that, and it does work.  The only other input file we could
> get rid of that way is nodes/lockoptions.h, which likewise contributes
> only a couple of enum type names.

Kinda wonder if those headers are even worth having. Plenty other enums in
primnodes.h.


> Not sure it's worth messing with --- both ways seem crufty, though for
> different reasons.

Not sure either.

Greetings,

Andres Freund