Feedback-ID: id4a34324:Fastmail
Date: Mon, 11 Jul 2022 15:27:58 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	David Rowley <dgrowleyml@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: automatically generating node support functions
Message-ID: <20220711222758.3bdgprqvvjwndn7k@awork3.anarazel.de>
References: <815831.1657494597@sss.pgh.pa.us>
 <45f508cb-e30b-c252-e081-4548deafa34c@enterprisedb.com>
 <1116889.1657553859@sss.pgh.pa.us>
 <1201553.1657562258@sss.pgh.pa.us>
 <CA+TgmoagVZJdt-pyNw-UK_YzrrFPGtT4oQ1LtbCeCSuAk8y0UQ@mail.gmail.com>
 <1229446.1657569262@sss.pgh.pa.us>
 <20220711201755.x5hmdailt63z2xo2@awork3.anarazel.de>
 <1239476.1657571885@sss.pgh.pa.us>
 <20220711213755.gwcysmuypke3wckg@awork3.anarazel.de>
 <1261926.1657577355@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1261926.1657577355@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220711222758.3bdgprqvvjwndn7k%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-07-11 18:09:15 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > I don't think it's worth worrying about this not working reliably for non
> > --enable-depend builds, there's a lot more broken than this.
>
> Well, *I* care about that, and I won't stand for making the
> non-enable-depend case significantly more broken than it is now.
>
> In particular, what you're proposing would mean that "make clean"
> followed by rebuild wouldn't be sufficient to update everything
> anymore; you'd have to resort to maintainer-clean or "git clean -dfx"
> after touching any node definition file, else gen_node_support.pl
> would not get re-run.  Up with that I will not put.

I'm not sure it'd have to mean that, but we could just implement the
dependency stuff independent of the existing autodepend logic. Something like:

# ensure that dependencies of
-include gen_node_support.pl.deps
node-support-stamp: gen_node_support.pl
	$(PERL) --deps $^.deps $^

I guess we'd have to distribute gen_node_support.pl.deps to make this work in
tarball builds - which is probably fine? Not really different than including
stamp files.

I'm not entirely sure how well either the existing or the sketch above works
when doing a VPATH build using tarball sources, and updating the files.

Greetings,

Andres Freund