Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBtxW-0001k5-GQ for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Jul 2022 08:12:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oBtxV-0000y3-5Z for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Jul 2022 08:12:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBtxU-0000xt-Sd for pgsql-hackers@lists.postgresql.org; Thu, 14 Jul 2022 08:12:28 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBtxQ-0000ZS-Mp for pgsql-hackers@lists.postgresql.org; Thu, 14 Jul 2022 08:12:28 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 96F4B3200681; Thu, 14 Jul 2022 04:12:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 14 Jul 2022 04:12:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1657786338; x=1657872738; bh=s ArGZDPvmVRT4sRjYTsvjHcqQgD4lev6yITyoB2rE80=; b=q2kZLjG6c8hbGpEbc KpvF6RaOollU5nuD8YB/wJYcyV3nJjj4B5pS0mj5kr3yvGpQnOjPzZAMli39MYom pwXXQ0iMJfRZhUmcf1YE1e+O8v7xDSqULs/9KTGxidR03Vwydjs4RN2g0ubNvmYN UD34ocKPBnAzyWO7xQhhz8xM8MDl+UEpc7FzMtJHNpWQTPWqRMOOAwc+i7IaIfnO Xh+wuoCoxF6/0aPcCvT3l9A7sHVZaD+BvkHWS1aJoXy4p8efO1xC7APDhHOj9Lg9 GE2gBh1UxxJXyxiBhWRlbnAFayzFrr8Bsnn/yqky9ygDa967gIPiX/BtyrJUsb2t YU24g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejlecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqeenuc ggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeejkeffgfdu fffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghr rhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 04:12:17 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id D0A1436E; Thu, 14 Jul 2022 10:12:14 +0200 (CEST) Date: Thu, 14 Jul 2022 10:12:14 +0200 From: Alvaro Herrera To: Dmitry Koval Cc: Zhihong Yu , PostgreSQL Hackers Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands Message-ID: <20220714081214.s7cie3vbtyyshzuz@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is not a review, but I think the isolation tests should be expanded. At least, include the case of serializable transactions being involved. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Pensar que el espectro que vemos es ilusorio no lo despoja de espanto, sólo le suma el nuevo terror de la locura" (Perelandra, C.S. Lewis)