Feedback-ID: ia2694551:Fastmail
Date: Thu, 14 Jul 2022 23:47:40 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: dilipbalaut@gmail.com, robertmhaas@gmail.com, michael@paquier.xyz,
	rjuju123@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: standby recovery fails (tablespace related) (tentative patch and
 discussion)
Message-ID: <20220714214740.drhmvdx2aseqgvvb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="hwk7mjf7k3wvtowq"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220713164345.j3n67rc45rpa4vop@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/20220714214740.drhmvdx2aseqgvvb%40alvherre.pgsql>
Precedence: bulk


--hwk7mjf7k3wvtowq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Here's a couple of fixups.  0001 is the same as before.  In 0002 I think
CheckTablespaceDirectory ends up easier to read if we split out the test
for validity of the link.  Looking at that again, I think we don't need
to piggyback on ignore_invalid_pages, which is already a stretch, so
let's not -- instead we can use allow_in_place_tablespaces if users need
a workaround.  So that's 0003 (this bit needs more than zero docs,
however.)

0004 is straightforward: let's check for bad directories before logging
about consistent state.

After all this, I'm not sure what to think of dbase_redo.  At line 3102,
is the directory supposed to exist or not?  I'm confused as to what is
the expected state at that point.  I rewrote this, but now I think my
rewrite continues to be confusing, so I'll have to think more about it.

Another aspect are the tests.  Robert described a scenario where the
previously committed version of this patch created trouble.  Do we have
a test case to cover that problematic case?  I think we should strive to
cover it, if possible.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The eagle never lost so much time, as
when he submitted to learn of the crow." (William Blake)

--hwk7mjf7k3wvtowq
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v25-0001-Fix-replay-of-create-database-records-on-standby.patch"