Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDmO6-0006uT-Eg for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 12:31:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmO5-00052C-6b for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Jul 2022 12:31:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDmO4-0004xk-3d for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 12:31:40 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDmO0-0000KD-3L for pgsql-hackers@lists.postgresql.org; Tue, 19 Jul 2022 12:31:39 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 308955C00B3; Tue, 19 Jul 2022 08:31:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 19 Jul 2022 08:31:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1658233892; x=1658320292; bh=7 IdCqVeRSyherFCIljcutNbEknoY0Vbu/8pdYgsZbJs=; b=IJy5dqa8/Idz7pDkB ACcUmvVc0MkHw+7JjrRoJr/c9UBmyDha345MSY2l7W3o18cb8BrpjyMIK5W+NK+0 +3Up2mGSZyKb9VqtaKZsAvRzQFxDH71loCkj8WV31ZAtKCJHTEHHIT25rP34qzwQ ejf42Onk5UGwNMlBSoFYUZDPTBiBhRDIBqaGErXcfbPGZQOmIlGbTuIghIGNUIV7 Gp72hqPYaCw7vDjBqjEa1YSXq+iGJkyDGj/YNbSwQf5b9wfXXDRPxK5eZG9LLxvt AEtDtPs9r+K02x/wMfO7hfdGU7L0a2tTl//Y49zPWmZ3YNc4pJm5NZYCiXVdZvup LiPqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeltddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepkedthfekveduuefgueelteekgfejgeekueduudeuveeu vddufffggfetiefhvdefnecuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghdpvg hnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Jul 2022 08:31:31 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id C7454369; Tue, 19 Jul 2022 14:31:28 +0200 (CEST) Date: Tue, 19 Jul 2022 14:31:28 +0200 From: Alvaro Herrera To: Justin Pryzby Cc: pgsql-hackers@lists.postgresql.org Subject: Re: errdetail/errhint style Message-ID: <20220719123128.bht5slg4wef2a2p2@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220719120948.GF12702@telsasoft.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Jul-19, Justin Pryzby wrote: > https://www.postgresql.org/docs/current/error-style-guide.html#id-1.10.6.4.7 > > git grep 'errdetail("[[:lower:]]' > git grep 'errdetail(".*".*;' |grep -v '\."' Hmm, +1, though a few of these are still missing ending periods after your patch. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "The problem with the facetime model is not just that it's demoralizing, but that the people pretending to work interrupt the ones actually working." (Paul Graham)