Date: Wed, 20 Jul 2022 16:16:32 +0900 (JST)
Message-Id: <20220720.161632.1015243011930700175.horikyota.ntt@gmail.com>
To: sawada.mshk@gmail.com
Cc: amit.kapila16@gmail.com, osumi.takamichi@fujitsu.com,
 bdrouvot@amazon.com, pgsql-hackers@lists.postgresql.org, minsoo@amazon.com
Subject: Re: [BUG] Logical replication failure "ERROR: could not map
 filenode "base/13237/442428" to relation OID" with catalog modifying txns
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: 
 <CAD21AoAEt=w8Xi-pf=45RnXfirgP4-GukPMC7GZhE=WpD8MCBA@mail.gmail.com>
References: 
 <CAD21AoC=jJEaNx5ersq_nxUQtuE2KcH_Rip0rNOWnvoYwVdSOg@mail.gmail.com>
	<20220720.095808.772209644652657995.horikyota.ntt@gmail.com>
	<CAD21AoAEt=w8Xi-pf=45RnXfirgP4-GukPMC7GZhE=WpD8MCBA@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20220720.161632.1015243011930700175.horikyota.ntt%40gmail.com>
Precedence: bulk

At Wed, 20 Jul 2022 10:58:16 +0900, Masahiko Sawada <sawada.mshk@gmail.com> wrote in 
> On Wed, Jul 20, 2022 at 9:58 AM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> > Mmm. the patch changed that behavior. AllocateSnapshotBuilder always
> > allocate the array with a fixed size. SnapBuildAddCommittedTxn still
>  > assumes builder->committed.xip is non-NULL.  SnapBuildRestore *kept*
> > ondisk.builder.commited.xip populated with a valid array pointer. But
> > the patch allows committed.xip be NULL, thus in that case,
> > SnapBuildAddCommitedTxn calls repalloc(NULL) which triggers assertion
> > failure.
> 
> IIUC the patch doesn't allow committed.xip to be NULL since we don't
> overwrite it if builder->committed.xcnt is 0 (i.e.,
> ondisk.builder.committed.xip is NULL):

I meant that ondisk.builder.committed.xip can be NULL.. But looking
again that cannot be.  I don't understand what I was looking at at
that time.

So, sorry for the noise.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center