Feedback-ID: ia2694551:Fastmail
Date: Wed, 20 Jul 2022 12:50:49 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: dilipbalaut@gmail.com, robertmhaas@gmail.com, michael@paquier.xyz,
	rjuju123@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: standby recovery fails (tablespace related) (tentative patch and
 discussion)
Message-ID: <20220720105049.jk52353p6ce35idb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ugp6tm4ilhq6dt7x"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220714214740.drhmvdx2aseqgvvb@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/20220720105049.jk52353p6ce35idb%40alvherre.pgsql>
Precedence: bulk


--ugp6tm4ilhq6dt7x
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

v26 here.  I spent some time fighting the readdir() stuff for
Windows (so that get_dirent_type returns LNK for junction points)
but couldn't make it to work and was unable to figure out why.
So I ended up doing what do_pg_backup_start is already doing:
an #ifdef to call pgwin32_is_junction instead.  I remove the
newly added path_is_symlink function, because I realized that
it would mean an extra syscall everywhere other than Windows.

So if somebody wants to fix get_dirent_type() so that it works properly
on Windows, we can change all these places together.

I also change the use of allow_invalid_pages to
allow_in_place_tablespaces.  We could add a
separate GUC for this, but it seems overengineering.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Most hackers will be perfectly comfortable conceptualizing users as entropy
 sources, so let's move on."                               (Nathaniel Smith)

--ugp6tm4ilhq6dt7x
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v26-0001-Fix-replay-of-create-database-records-on-standby.patch"