Date: Wed, 20 Jul 2022 07:27:07 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Simon Riggs <simon.riggs@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Bernd Helmle <mailings@oopsware.de>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	pgsql-hackers@postgresql.org,
	Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Subject: Re: Allowing REINDEX to have an optional name
Message-ID: <20220720122707.GI12702@telsasoft.com>
References: 
 <CANbhV-EmOh-XTssH5TwannC2S1VDN5zK-b+oZKs8UdyUtc2oUw@mail.gmail.com>
 <YrvWoAsaX/gUG2re@paquier.xyz>
 <CANbhV-EL4+RK49Qmk66zFmTiEEhT6TKia0ow_t5zogV1-FfAEw@mail.gmail.com>
 <1386216.1656884491@sss.pgh.pa.us>
 <YsKP6wJ0+XvF+6/8@paquier.xyz>
 <CANbhV-H2Y=jM1QVRkT-OOa2+KPTd3po+=2LmZ35DmTidjRovGg@mail.gmail.com>
 <CANbhV-GzM_KukbDm6qWFRfpkv==uDjXOOU-KMHqRz71ojce_rg@mail.gmail.com>
 <YtOqA7ldcJQADEE8@paquier.xyz>
 <20220719022652.GE12702@telsasoft.com>
 <YtYvbtPCW2ztdUHy@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YtYvbtPCW2ztdUHy@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220720122707.GI12702%40telsasoft.com>
Precedence: bulk

On Tue, Jul 19, 2022 at 01:13:34PM +0900, Michael Paquier wrote:
> > It looks like you named the table "toast_relfilenodes", but then also store
> > to it data for non-toast tables.
> 
> How about naming that index_relfilenodes?  One difference with what I
> posted previously and 5fb5b6 is the addition of an extra regclass that
> stores the parent table, for reference in the output.

Looks fine

> -	'CREATE TABLE toast_relfilenodes (parent regclass, indname regclass, relfilenode oid);'
> +	'CREATE TABLE index_relfilenodes (parent regclass, indname regclass, relfilenode oid);'

-- 
Justi