public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Thomas Munro <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Date: Thu, 21 Jul 2022 13:25:05 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2022-Jul-21, Alvaro Herrera wrote:

> Yeah, I think that would reduce cruft.  I'm not sure this is more
> against backpatching policy or less, compared to adding a separate
> GUC just for this bugfix.

cruft:

    {
        {"allow_recovery_tablespaces", PG_POSTMASTER, WAL_RECOVERY,
            gettext_noop("Continues recovery after finding invalid database directories."),
            gettext_noop("It is possible for tablespace drop to interfere with database creation "
                         "so that WAL replay is forced to create fake database directories. "
                         "These should have been dropped by the time recovery ends; "
                         "but in case they aren't, this option lets recovery continue if they "
                         "are present.  Note that these directories must be removed manually afterwards."),
            GUC_NOT_IN_SAMPLE
        },
        &allow_recovery_tablespaces,
        false,
        NULL, NULL, NULL
    },

This is not a very good explanation, but I don't know how to make it
better.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"I think my standards have lowered enough that now I think 'good design'
is when the page doesn't irritate the living f*ck out of me." (JWZ)

view thread (111+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox