Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oExJI-0007ul-DD for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Jul 2022 18:23:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oExJH-0001az-5x for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Jul 2022 18:23:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oExJG-0001Ur-Sg for pgsql-hackers@lists.postgresql.org; Fri, 22 Jul 2022 18:23:34 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oExJE-0006JU-HF for pgsql-hackers@postgresql.org; Fri, 22 Jul 2022 18:23:33 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 48D2C32004F8; Fri, 22 Jul 2022 14:23:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Jul 2022 14:23:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1658514210; x=1658600610; bh=c sUDmA4wqojvuMcADXL4jne6sDi3Pht/R8eU9eoHFCs=; b=2NPc1XMPZhVHFQAwg npRBZGURTp0L2UM9Bq5k3A0hdRjm/Qb+r9oJGDBtVWYojbqCBYzJXuplja54Gb4z E8psfuYtDovTfzOofQp1vIc1Gbj/tzA77oR4dNO0rJzjy5F3aVArfmok9NJVRSpz o1R5uwIZ0Zrk4oIfuCiw7VWlgJR5ammELhpISnWv7spn0rbpEuxVALdRqMIO/Lw/ KWqj6SBDmyTFaLTbK1WtOZaRq6AHFJhqYZb7IC9AuHf3fSB1wJIZEWl/KZxAJs09 /b3olE75dhyborbb25rn0+rnsNLIJtSWAGxaQjEmbk7YVn3w3jzyt874Rt2Lc618 S2arQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtvddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhv rghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorh hgqeenucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeej keffgfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtoh hmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghl vhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 14:23:29 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 28FB5369; Fri, 22 Jul 2022 20:23:23 +0200 (CEST) Date: Fri, 22 Jul 2022 20:23:23 +0200 From: Alvaro Herrera To: Andrew Dunstan Cc: Justin Pryzby , pgsql-hackers@postgresql.org, Andres Freund Subject: Re: make -C libpq check fails obscurely if tap tests are disabled Message-ID: <20220722182323.4org2cermfs4j6zl@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2de755eb-1ad8-b73e-5f78-4fdb366718a4@dunslane.net> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-Jul-21, Andrew Dunstan wrote: > On 2022-07-21 Th 04:53, Alvaro Herrera wrote: > > Here's a different take. Just assign the variable separately. > > Nice, I didn't know you could do that. It's not very common -- we do have some target-specific variable assignments, but none of them use 'export'. I saw somewhere that this works from Make 3.77 onwards, and we require 3.80, so it should be okay. The buildfarm will tell us ... -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Industry suffers from the managerial dogma that for the sake of stability and continuity, the company should be independent of the competence of individual employees." (E. Dijkstra)