public inbox for [email protected]
help / color / mirror / Atom feedFrom: Justin Pryzby <[email protected]>
To: Tom Lane <[email protected]>
Cc: Maciek Sakrejda <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: [email protected]
Subject: Re: warn if GUC set to an invalid shared library
Date: Fri, 22 Jul 2022 14:14:43 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAKFQuwaRUiA2UOA7QvRaOnaWD1sbv3h3xB+W9KGSDkcsTpG3oA@mail.gmail.com>
<164378196169.19783.12147751717180735532.pgcf@coridan.postgresql.org>
<CA+TgmoYHTu=Qb+OW3v4qR4KRY=Fc0KDvA0FwXuQ8iKrcXHUpbg@mail.gmail.com>
<[email protected]>
<CAOtHd0CQxJCAF77T+0buj57p5EycwzELfyAWMhJ8oZ3nzCZ6fw@mail.gmail.com>
<[email protected]>
<CAOtHd0Ca3o_YX-2xC+0SOJD242QDHKCS16bG2AX9QQkKsdBF7Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
On Fri, Jul 22, 2022 at 03:00:23PM -0400, Tom Lane wrote:
> Justin Pryzby <[email protected]> writes:
> > On Fri, Jul 22, 2022 at 01:53:21PM -0400, Tom Lane wrote:
> >> This indicates that the warning is being issued in the wrong place.
> >> It's okay if it comes out during ALTER SYSTEM. It's not okay if it
> >> comes out during server start; then it's just an annoyance.
>
> > The previous patch version checked if (!IsUnderPostmaster()) before warning.
> > Is there a better way ?
>
> > ALTER SYSTEM uses PGC_S_FILE, the same as during startup..
>
> Shouldn't you be doing this when the source is PGC_S_TEST, instead?
> That's pretty much what it's for. See check_default_table_access_method
> and other examples.
That makes sense, but it doesn't work for ALTER SYSTEM, which uses PGC_S_FILE.
postgres=# ALTER SYSTEM SET shared_preload_libraries =a;
2022-07-22 14:07:25.489 CDT client backend[23623] psql WARNING: source 3
WARNING: source 3
2022-07-22 14:07:25.489 CDT client backend[23623] psql WARNING: could not access file "$libdir/plugins/a"
2022-07-22 14:07:25.489 CDT client backend[23623] psql DETAIL: The server will currently fail to start with this setting.
2022-07-22 14:07:25.489 CDT client backend[23623] psql HINT: If the server is shut down, it will be necessary to manually edit the postgresql.auto.conf file to allow it to start again.
postgres=# ALTER SYSTEM SET default_table_access_method=abc;
Breakpoint 1, check_default_table_access_method (newval=0x7ffe4c6fe820, extra=0x7ffe4c6fe828, source=PGC_S_FILE) at tableamapi.c:112
--
Justin
view thread (29+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: warn if GUC set to an invalid shared library
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox