Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGORO-0005wH-9e for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Jul 2022 17:33:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGORM-0000zj-IO for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Jul 2022 17:33:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGORM-0000za-6h for pgsql-hackers@lists.postgresql.org; Tue, 26 Jul 2022 17:33:52 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGORG-0008F3-Sz for pgsql-hackers@postgresql.org; Tue, 26 Jul 2022 17:33:51 +0000 Received: by mail-pj1-x1036.google.com with SMTP id e8-20020a17090a280800b001f2fef7886eso1312566pjd.3 for ; Tue, 26 Jul 2022 10:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=OCY7kCgMzASX4h6bjFSwojaGxS+dx9hma7ylIz9kW2o=; b=efEO1HgKe1YhLmcTk8d0tcCIDPz8O4tw8YkcWSAR9+bnha2Vb63J8+v0qqqXMmljAU NvJvLhVxPmd/nB9kFB5nDF33racjER5LNUoxFLaAY9pRxU+hTrBBCy7WkuXqU6ZJDPaX W9+4jaTyuDd9oZCPz5KudkvQPQKxKQdT1A6Sx/XgFzVC1d0CW7qHiIxuFMAkPf0qBOG7 ENewTBU1j0D5rTOq2e1zOoLFpOXO4zXVRxLDMqh/Vrfc/D9WZueMtWSjxfFfMMc0QW6I En9/8BJMZPwwLzuPAIw1tBKDc3ogPFLIWd6AwkzBSEhY8Pka1rZRtI9xsPjSI+iCqfE8 YF1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=OCY7kCgMzASX4h6bjFSwojaGxS+dx9hma7ylIz9kW2o=; b=AtcOS964SszzHWyJtw5g+ZMfxiUUdfBKPCv1UCRJ6miaPdwgLtEZ871nNQ5POVPUWa FnqcEJSQzpbt+KUyVPJJ4gYI8oWltbHkOOEwcejysi3YuyAy2Bpw8dDUNe71hzKctNlA Gx4r+xQZcmN0NuC6wy7QhC1U0ZM5DG0miZAXb4Fz89ROKjQ2i/WcPvbT4rSKZ2yZldUb rOKkVnthZiVpysTTYuFwoSLpOIsTQga04ME7+ujiXA2GUuZqIMNBUiYKnzWtpdiZ7s6z XoNohGc+PBM1ey+7qN3DC1rF58F7uiVItq4dWVd2XCHUlbKdGxuIyzfdU1+MGoEC1k9g w2oA== X-Gm-Message-State: AJIora+JXiGhQFgF8WW4ewkjhPpyrkkYYM4BmD3WCMr1R98v9KVrcZXI MEmxWNfRMcQd+sPMQfMi437p3f6+ILM= X-Google-Smtp-Source: AGRyM1tNNItl4l8e2cginSuZWgZDWZ71uMEtFE5wP72jf4owDLjF7zOtE02dp2s3owQGUZegs95JCQ== X-Received: by 2002:a17:90a:cb88:b0:1f2:166c:fd3f with SMTP id a8-20020a17090acb8800b001f2166cfd3fmr257671pju.133.1658856825471; Tue, 26 Jul 2022 10:33:45 -0700 (PDT) Received: from nathanxps13 ([50.54.155.70]) by smtp.gmail.com with ESMTPSA id k18-20020a6568d2000000b0041a8f882e5bsm9650732pgt.42.2022.07.26.10.33.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 10:33:44 -0700 (PDT) Date: Tue, 26 Jul 2022 10:33:43 -0700 From: Nathan Bossart To: pgsql-hackers@postgresql.org Subject: out of date comment in commit_ts.c Message-ID: <20220726173343.GA154110@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi hackers, I noticed that commit_ts.c has the following comment: * XLOG interactions: this module generates an XLOG record whenever a new * CommitTs page is initialized to zeroes. Also, one XLOG record is * generated for setting of values when the caller requests it; this allows * us to support values coming from places other than transaction commit. * Other writes of CommitTS come from recording of transaction commit in * xact.c, which generates its own XLOG records for these events and will * re-perform the status update on redo; so we need make no additional XLOG * entry here. IIUC the ability for callers to request WAL record generation is no longer possible as of 08aa89b [0]. Should the second sentence be removed? [0] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=08aa89b -- Nathan Bossart Amazon Web Services: https://aws.amazon.com