Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGnfN-000888-7A for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 20:30:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnfL-0000dH-ND for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 20:29:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGnfL-0000UR-B7 for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 20:29:59 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGnfI-0004Er-Lo for pgsql-hackers@postgresql.org; Wed, 27 Jul 2022 20:29:58 +0000 Received: by mail-pj1-x1032.google.com with SMTP id c19-20020a17090ae11300b001f2f94ed5c6so3700788pjz.1 for ; Wed, 27 Jul 2022 13:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d/RTL+cJd/6T2amcj+yK2QCwMfc3mDfukKJ2w92CzcU=; b=a4M36ODZd4XdPeZSfPx1tFiYUWRreMBU6WYh3VMR1VgO9+8HSy4d7Xx4exD9CSyoHY N5meyfMAzyiR8qnAaIKE8Mccif99+vCtNRymG0uosbqOXXVeX4JXsmF2e9qHXA2xs+wn 6+kFVgtehlZxeJfeIdfTKCkTWa/j06OgEc5HIxg3YC1OjqgzgEPqSPxylROa6Hr3g4iF WfElLuGg98JddWIaU24u8V/XczmhjXLoMQ3Vnl/nl7GZJFWnxvPkRe46n8Z9K2nHwFK5 qNEf/GtsXBdsvnxgS0Ir11e3DoZLCcbBeAuIVtGZnumVMHWMB7FuSGhl0czfUa7g/H3w 17SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d/RTL+cJd/6T2amcj+yK2QCwMfc3mDfukKJ2w92CzcU=; b=xZEwg8sVjriCMU95Mi1yTfB/tWYVdqPE/jQUyuRgk2jdCXVTjk7n+j5ioTyiniTKGV yQXcjacKSi26n3OS+xg6M7NHV9LU1p3ug9O/65fjoUGyEHyDFSG8+8vAJRoloUJZl+16 tSMtgrCxG9MNLpokCtRunCukYKG9bZvlQOkpvb4F9Y+LRAX6R0fGUY0oeq3jfRX0CKmw KQHlSZGFCUJO94PfuYsvE6WDs57basgzZwedrLUcFzTTd9kEcj5rh4ENjR562cw508SW nixaM4bDBHkdRTE+B7p1XuffodiyTasSzOwfaBDGTv9msjhW0L9xZ1vMh/U9IXVvWZR3 PujA== X-Gm-Message-State: AJIora+vR/dkDDPhrrmBvDjQAanFXUcQCA93j8LyzOhHD+dsSoSFj3UA LeXmMv5jZta2z7VCNIia+YlabdXh6yI= X-Google-Smtp-Source: AGRyM1uBKv9lS5phtnRF+w7GFbP7S4MvRCIn1YCqGGwX3YRp9F5loW8HDWfBYxl5ZtOn/EzJV1b61g== X-Received: by 2002:a17:902:ecc2:b0:16d:6146:3337 with SMTP id a2-20020a170902ecc200b0016d61463337mr19811541plh.139.1658953795201; Wed, 27 Jul 2022 13:29:55 -0700 (PDT) Received: from nathanxps13 ([50.54.155.70]) by smtp.gmail.com with ESMTPSA id k18-20020a628412000000b0052ba5ebfe30sm14594679pfd.99.2022.07.27.13.29.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 13:29:54 -0700 (PDT) Date: Wed, 27 Jul 2022 13:29:52 -0700 From: Nathan Bossart To: pgsql-hackers@postgresql.org Subject: Re: out of date comment in commit_ts.c Message-ID: <20220727202952.GA226176@nathanxps13> References: <20220726173343.GA154110@nathanxps13> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: <20220726173343.GA154110@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 26, 2022 at 10:33:43AM -0700, Nathan Bossart wrote: > IIUC the ability for callers to request WAL record generation is no longer > possible as of 08aa89b [0]. Should the second sentence be removed? Here's a patch. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com --RnlQjJ0d97Da+TV1 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="fix_commit_ts_comment.patch" diff --git a/src/backend/access/transam/commit_ts.c b/src/backend/access/transam/commit_ts.c index 4dc8d402bd..9aa4675cb7 100644 --- a/src/backend/access/transam/commit_ts.c +++ b/src/backend/access/transam/commit_ts.c @@ -7,13 +7,10 @@ * for each transaction. * * XLOG interactions: this module generates an XLOG record whenever a new - * CommitTs page is initialized to zeroes. Also, one XLOG record is - * generated for setting of values when the caller requests it; this allows - * us to support values coming from places other than transaction commit. - * Other writes of CommitTS come from recording of transaction commit in - * xact.c, which generates its own XLOG records for these events and will - * re-perform the status update on redo; so we need make no additional XLOG - * entry here. + * CommitTs page is initialized to zeroes. Other writes of CommitTS come + * from recording of transaction commit in xact.c, which generates its own + * XLOG records for these events and will re-perform the status update on + * redo; so we need make no additional XLOG entry here. * * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California --RnlQjJ0d97Da+TV1--