Feedback-ID: ia2694551:Fastmail
Date: Fri, 29 Jul 2022 12:59:03 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: thomas.munro@gmail.com, tgl@sss.pgh.pa.us, boekewurm+postgres@gmail.com,
	pgsql-hackers@postgresql.org
Subject: Re: standby recovery fails (tablespace related) (tentative patch and
 discussion)
Message-ID: <20220729105903.xuiw23kpcdphcvel@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220729.142008.340873830395327221.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220729105903.xuiw23kpcdphcvel%40alvherre.pgsql>
Precedence: bulk

On 2022-Jul-29, Kyotaro Horiguchi wrote:

> At Fri, 29 Jul 2022 11:27:01 +1200, Thomas Munro <thomas.munro@gmail.com> wrote in 
> > Maybe it just needs a replication slot?  I see:
> > 
> > ERROR:  requested WAL segment 000000010000000000000003 has already been removed
> 
> Agreed, I see the same.  The same failure can be surely reproducible
> by inserting wal-switch+checkpoint after taking backup [1].  And it is
> fixed by the attached.

WFM, pushed that way.  I added a slot drop after the pg_stat_replication
count check to be a little less intrusive. Thanks Matthias for
reporting.  (Note that the Cirrus page has a download link for the
complete logs as artifacts).

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I'm always right, but sometimes I'm more right than other times."
                                                  (Linus Torvalds)