Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oI9CV-0007Xd-J0 for pgsql-hackers@arkaria.postgresql.org; Sun, 31 Jul 2022 13:41:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oI9CU-0000Bj-8q for pgsql-hackers@arkaria.postgresql.org; Sun, 31 Jul 2022 13:41:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oI9CT-0000Ba-SJ for pgsql-hackers@lists.postgresql.org; Sun, 31 Jul 2022 13:41:45 +0000 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oI9CM-0004Rx-9m for pgsql-hackers@postgresql.org; Sun, 31 Jul 2022 13:41:44 +0000 Received: by mail-qv1-xf35.google.com with SMTP id d1so5159715qvs.0 for ; Sun, 31 Jul 2022 06:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc; bh=dhk0+/SCcu5vOS7/gGkGI2Q7UdW8MccawJCLJg+OELQ=; b=7bjy4dkeM9YLLxsCpQPjZiQ691jzwcymPDziuZDmGkids0dtvsqHYK7XVh6wR1lrzr JhxvCq9tzDgYegTH/MDoLx9EW7bOKWOxsydNzOGy+RX1RVFF83yphJHoAiUWAMkU4SSx DIv8f7pZi0+FtC2b9LI/XWBhST7FYjLLa8T+H5JaYnVks15STpP1UcjELOXV9jXzfgzP cEBYYxeuJ+eRsI894pUj8qVuzFvV16WHQpFHzvHkKx5V7KP4YlWfzC+x6Ln6SuzyTZJB x8Gxql2xCV8S3RpSodaRthDIFuDi083XiF0WOV4NZhRp+0nIHWo0pgim2tBfxbHHOxzb FTDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc; bh=dhk0+/SCcu5vOS7/gGkGI2Q7UdW8MccawJCLJg+OELQ=; b=49HllF6bXrCjPdUnL3abZwDuf+3AcsqDbw1GPzU6oML6aykuEdCr+WxkLCDJU3xbaj WJWutlUT2aUg1+HDbqpLceRau1/0rxrvFhAhNPhBhbJuRBcpZ+YFRES42V7iySXraWea R5QSZHrKDq30zifC2V/uCyXoDiR1X4mOMvEITNUhAYJ/BaG1wCBap0AE5zyuo9vr32CJ ff2TJhNaNW78J/IfvnhwGUeaf9Ti+I/Nm7hnG8k5mh0GoGzvZnMXokUgnGOXlsfegdjT CG3vOHqEcEh53i+pbONWhE8QnaBnfzJdeQQeClno2aCh6mVkJ71O3CpUaIr6Hro/N6py 2Vdg== X-Gm-Message-State: ACgBeo2li1e+elNsB72BBMojBVtcqu49AoELTSgFnJXh+Zy4eI6yhAJK vOnkH04CnTQOCocrtOcvFQCc9Q== X-Google-Smtp-Source: AA6agR6Zcfa+ieDwS2XyDIjq+w9mm9ZVh6JL0u0eRRxqdmI6DDtcjtnI/qEkXiaGnJKgY7y3v5nJ+w== X-Received: by 2002:a05:6214:23c8:b0:45f:b582:346e with SMTP id hr8-20020a05621423c800b0045fb582346emr10237307qvb.109.1659274897082; Sun, 31 Jul 2022 06:41:37 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id s2-20020a05620a29c200b006af0ce13499sm6800418qkp.115.2022.07.31.06.41.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Jul 2022 06:41:36 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 89ABE80288C; Sun, 31 Jul 2022 08:41:35 -0500 (CDT) Date: Sun, 31 Jul 2022 08:41:35 -0500 From: Justin Pryzby To: Peter Eisentraut Cc: pgsql-hackers@postgresql.org Subject: pg_upgrade errno Message-ID: <20220731134135.GY15006@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Since 3a769d823 (pg_upgrade: Allow use of file cloning) file.c has had: - if (ioctl(dest_fd, FICLONE, src_fd) < 0) - { - unlink(dst); - pg_fatal("error while cloning relation \"%s.%s\" (\"%s\" to \"%s\"): %s", - schemaName, relName, src, dst, strerror(errno)); - } But errno should be saved before strerror/%m. -- Justin