Date: Mon, 8 Aug 2022 21:43:17 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: John Naylor <john.naylor@enterprisedb.com>,
	Andres Freund <andres@anarazel.de>,
	John Naylor <jcnaylor@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: optimize lookups in snapshot [sub]xip arrays
Message-ID: <20220809044317.GA1443152@nathanxps13>
References: <20220804221551.GA1090071@nathanxps13>
 <CAFBsxsGmNefB-LAo8hNXLDAwWN0vHXc6H2A+NfFUQrj=rn50DQ@mail.gmail.com>
 <20220805202510.GA1208450@nathanxps13>
 <20220805220434.6h2aa7eww5rxird6@awork3.anarazel.de>
 <20220806181326.GA1216305@nathanxps13>
 <20220806212522.GA1221353@nathanxps13>
 <CAFBsxsFCtNAxbmSc9dc6xbF4HguBmMB7CDjm+8Z7uWEfTN+7oA@mail.gmail.com>
 <CALj2ACVsE23YMWU5Sn2aZwMq_0m-rK3r6ARZXUM11bSsZnKm+Q@mail.gmail.com>
 <20220808230716.GB1393216@nathanxps13>
 <CALj2ACUQVxHfOUKkhf4RAqmGGvKtzoUBMchHCgNyV+w8a-Yx1A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CALj2ACUQVxHfOUKkhf4RAqmGGvKtzoUBMchHCgNyV+w8a-Yx1A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220809044317.GA1443152%40nathanxps13>
Precedence: bulk

On Tue, Aug 09, 2022 at 09:40:15AM +0530, Bharath Rupireddy wrote:
> Isn't it a good idea to capture the above two points as comments in
> port/pg_lfind.h just to not lose track of it? I know these are present
> in the hackers thread, but having them in the form of comments helps
> developers who attempt to change or use the new function.

Hm.  My first impression is that this is exactly the sort of information
that is better captured on the lists.  I'm not sure that the lack of such
commentary really poses any threat for future changes, which would need to
be judged on their own merit, anyway.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com