Date: Thu, 18 Aug 2022 00:16:37 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-hackers@postgresql.org,
	Tomas Vondra <tomas.vondra@postgresql.org>,
	Peter Smith <smithpb2250@gmail.com>
Subject: Re: shadow variables - pg15 edition
Message-ID: <20220818051637.GK26426@telsasoft.com>
References: <20220817145434.GC26426@telsasoft.com>
 <CAApHDvqBBqF=wmV5azrO7h3VwpwQo+JFBQ+g=E6wVUhKcqR8gA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvqBBqF=wmV5azrO7h3VwpwQo+JFBQ+g=E6wVUhKcqR8gA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220818051637.GK26426%40telsasoft.com>
Precedence: bulk

On Thu, Aug 18, 2022 at 03:17:33PM +1200, David Rowley wrote:
> I'm probably not the only committer to want to run a mile when they
> see someone posting 17 or 26 patches in an email. So maybe "bang for
> buck" is a better method for getting the ball rolling here.  As you
> know, I was recently bitten by local shadows in af7d270dd, so I do
> believe in the cause.
> 
> What do you think?

You already fixed the shadow var introduced in master/pg16, and I sent patches
for the shadow vars added in pg15 (marked as such and presented as 001-008), so
perhaps it's okay to start with that ?

BTW, one of the remaining warnings seems to be another buglet, which I'll write
about at a later date.

-- 
Justin