Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oQKTD-00026H-74
	for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 03:20:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oQKTC-0005rb-2L
	for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 03:20:50 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1oQKTB-0005rS-Oq
	for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 03:20:49 +0000
Received: from out1-smtp.messagingengine.com ([66.111.4.25])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1oQKT9-00016I-HL
	for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 03:20:48 +0000
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
	by mailout.nyi.internal (Postfix) with ESMTP id C361D5C0058;
	Mon, 22 Aug 2022 23:20:46 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute2.internal (MEProxy); Mon, 22 Aug 2022 23:20:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	cc:cc:content-transfer-encoding:content-type:date:date:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to; s=fm1; t=1661224846; x=
	1661311246; bh=yo3WVmrhp3uMhpBMBCdnXxqzbTRntZx0X4sBIr931uc=; b=Z
	M5llv3cyzyKDnGmkRwY6dT4i04MFb5zhvGxjeVHmmTXtxWW9VXu12XFnGKWYhUzm
	wsVfdCjs+gZpl6+TGdb9sOXGFHa8tv3r6aCENIdYU2WnIdZ9csNiyv2trnQcN+/3
	7K/n3yWVRd5akutfBP9xWYQBPcLgpkFRkUAyVSjlhZdpMYh1w9Whp989b0W579IX
	pQiO5vH/YFeh4XYxCZf0jrAcakqki9s6VHDvAxAdz2XUbQhsW1Z3pau1EEUjMAkg
	fN3UJ366kWf8SdlvfNzZ1Hsey80OZwGsyRytUQzQLrEdj1Y3nTJN4GJUEt1t7tKr
	YTK5J/A/IObv0LS91J9NQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:date:date:feedback-id:feedback-id:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661224846; x=
	1661311246; bh=yo3WVmrhp3uMhpBMBCdnXxqzbTRntZx0X4sBIr931uc=; b=P
	Dt6c1vKgft5lHxGuZyj4KbR3MMWmRFnqY9t3eaiNlvF8lK63lt71DpTT+t3J8ChJ
	HdIOXmIvf3DCjw+urokb++qMVHajL/znHNVbrODDTauy+pj0haRUNp16k53/wXla
	kDF0A2sLyISBThEOFqSCeG77s8JetRT6fs8FwQ6k9XTHgrrGh/a6RxR1I5mhjVS/
	iJlZP20kcaVT+ABR2ydphLq8xfYko5VIIIsI2neVipIb7LVarD5g2RvisRVIC5Qc
	ODVABiLeq6Mlq4yyqt/cFOWUxMv11ffEmxAPiREr4Jz+VZHBwddOSLRCesZNjmPK
	QOpE2k72QuA1tvvwFDD/Q==
X-ME-Sender: <xms:jkcEY7EZXd0nqEi_7dcO7vJNxBMsbK6tu-ILwOZ8iB4L3qJiBMyB5w>
    <xme:jkcEY4US21qNqdboaF2UWVG9ybNdXLNs-62DTTsg5AOcTjYNAJK0SLwY1jXf1_LcC
    tbH-au9jWZhfydJqg>
X-ME-Received: 
 <xmr:jkcEY9K45uFejgo2RWAW2E0xeHLYj9aYF7QNFxRd0NHrzjVQMPvudcmfsV8WljO-ilQsTUyZH4B2ippSThtp5n-r9RG6TqdhsgutYjcM3RtTuv2tc7CQuxLvVDWa>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedvfedrvdeikedgjeduucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtugfgjgesth
    ekredttddtudenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshes
    rghnrghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepuddtieegleejheeujeeive
    egueelhfekleeuffdukeduleduffehfffgteeivefhnecuvehluhhsthgvrhfuihiivgep
    tdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigvlhdrug
    gv
X-ME-Proxy: <xmx:jkcEY5HJxDua8ssW7CL7_o-M7FznY1m_zsfzit6Ck6GftXgYtpUvWA>
    <xmx:jkcEYxXd0QuSWEeXWEGyK2fnvMiD5s_cEhA4YP6oOxKTNyfwukD2yQ>
    <xmx:jkcEY0OcPhuyMtBYM3jjlBDxc0XbZ3-tEZyQ_X_aG6vOPeSsyXEPIg>
    <xmx:jkcEY-iXMZr0E_b7QCXh5HN6WTRz96Ib8xMqnHe_ADFebh0QDrM39w>
Feedback-ID: id4a34324:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 22 Aug 2022 23:20:46 -0400 (EDT)
Date: Mon, 22 Aug 2022 20:20:45 -0700
From: Andres Freund <andres@anarazel.de>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: bdrouvot@amazon.com, stark@mit.edu, pgsql-hackers@lists.postgresql.org
Subject: Re: shared-memory based stats collector - v70
Message-ID: <20220823032045.kms7w6ldx5mg2a4e@awork3.anarazel.de>
References: <20220809165319.jdzd225xohqf6o57@awork3.anarazel.de>
 <20220810.113910.92411510444435201.horikyota.ntt@gmail.com>
 <3d853c6f-445f-782e-eab0-525729952d4c@amazon.com>
 <20220822.113214.157880042751504547.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220822.113214.157880042751504547.horikyota.ntt@gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20220823032045.kms7w6ldx5mg2a4e%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-08-22 11:32:14 +0900, Kyotaro Horiguchi wrote:
> At Wed, 10 Aug 2022 14:02:34 +0200, "Drouvot, Bertrand" <bdrouvot@amazon.com> wrote in 
> > what about?
> > 
> > +               /*
> > +                * Acquire the LWLock directly instead of using
> > pg_stat_lock_entry_shared()
> > +                * which requires a reference.
> > +                */
> > 
> > 
> > I think that's more consistent with other comments mentioning LWLock
> > acquisition.
> 
> Sure. Thaks!. I did that in the attached.

Pushed, thanks!

Greetings,

Andres Freund