Feedback-ID: id4a34324:Fastmail
Date: Tue, 23 Aug 2022 16:24:45 -0700
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	samay sharma <smilingsamay@gmail.com>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Inconsistencies around defining FRONTEND
Message-ID: <20220823232445.jpp56meso7fgrpns@awork3.anarazel.de>
References: <20220820194550.725755r6fj2ro3rx@awork3.anarazel.de>
 <CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220823232445.jpp56meso7fgrpns%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-08-23 17:24:30 -0400, Robert Haas wrote:
> On Sat, Aug 20, 2022 at 3:46 PM Andres Freund <andres@anarazel.de> wrote:
> > Unfortunately, the remaining uses of FRONTEND are required. That's:
> > - pg_controldata, via #define
> > - pg_resetwal, via #define
> > - pg_rewind, via -DFRONTEND, due to xlogreader.c
> > - pg_waldump, via #define and -DFRONTEND, due to xlogreader.c, xlogstats.c, rmgrdesc/*desc.c
>
> Actually, I think we could fix these pretty easily too.

I just meant that they're not already obsolete ;)


> See attached.

Just to make sure I understand - you're just trying to get rid of the #define
frontends, not the -DFRONTENDs passed in from the Makefile? Because afaics we
still need those, correct?

Greetings,

Andres Freund