Date: Wed, 24 Aug 2022 21:14:18 -0700
From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, robertmhaas@gmail.com
Subject: Re: static libpq (and other libraries) overwritten on aix
Message-ID: <20220825041418.GA748995@rfd.leadboat.com>
References: <20220817190154.nnu27rvcleu2764m@awork3.anarazel.de>
 <20220818045929.GB410601@rfd.leadboat.com>
 <20220818160357.w7cbzw6o7eacqe72@awork3.anarazel.de>
 <20220819055643.GB442595@rfd.leadboat.com>
 <20220820083522.i5wocl3xugarzxcn@awork3.anarazel.de>
 <20220820174213.d574qde4ptwdzoqz@awork3.anarazel.de>
 <20220825034304.tb5ogv2fdzfijagw@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220825034304.tb5ogv2fdzfijagw@awork3.anarazel.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20220825041418.GA748995%40rfd.leadboat.com>
Precedence: bulk

On Wed, Aug 24, 2022 at 08:43:04PM -0700, Andres Freund wrote:
> On 2022-08-20 10:42:13 -0700, Andres Freund wrote:
> > 0004 aix: when building with gcc, tell gcc we're building a shared library
> > 
> >   That's the gcc -shared issue I explained in the email I'm replying to.
> > 
> >   We should probably consider building executables with -shared-libgcc too,
> >   that shrinks them a decent amount (e.g. 1371684 -> 1126765 for psql). But
> >   I've not done that here.
> > 
> > 
> > 0005 aix: No need to use mkldexport when we want to export all symbols
> > 
> >   This makes the building of shared libraries a lot more similar to other
> >   platforms. Export files are only used when an exports.txt is present and
> >   there's no more intermediary static libraries.
> > 
> > 
> > 0006 configure: Expand -fvisibility checks to more compilers, add -qvisibility
> > 
> >   This isn't strictly speaking part of the same "thread" of work, but I don't
> >   want to touch aix more often than I have too... I'll post it in the other
> >   thread too.
> > 
> >   I did just test that this passes at least some tests on aix with xlc and
> >   solaris with sunpro.
> 
> Any comments here?

I don't know much about them, but they sound like the sort of thing that can't
cause subtle bugs.  If they build and test the first time, they're probably
valid.  You may as well push them.