Date: Thu, 25 Aug 2022 13:06:00 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: talk to ben <blo.talkto@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Robert Haas <robertmhaas@gmail.com>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Michael Paquier <michael@paquier.xyz>,
	Magnus Hagander <magnus@hagander.net>,
	Stephen Frost <sfrost@snowman.net>
Subject: Re: archive modules
Message-ID: <20220825200600.GA1465148@nathanxps13>
References: <20220707151157.cakxxwwadchkov35@alvherre.pgsql>
 <2985823.1657208900@sss.pgh.pa.us>
 <20220707165908.GB2251016@nathanxps13>
 <CAPE8EZ6yhCZjMTRR2Jp=mMCEuO9YnpmUWYMTuOzo7zaJuqwq8A@mail.gmail.com>
 <20220823173930.GB1207981@nathanxps13>
 <727557.1661276860@sss.pgh.pa.us>
 <CAPE8EZ7vh6gdgHjAYhuvjUJzvZm7PGeZQaDDBfSYmDmfa+QeFg@mail.gmail.com>
 <20220824221723.GA1347845@nathanxps13>
 <CAPE8EZ4F3d06diQ27D=5qxN2FVHA0qsaRghzkLDf=KZHEUN7rg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="n8g4imXOkfNTN/H1"
Content-Disposition: inline
In-Reply-To: 
 <CAPE8EZ4F3d06diQ27D=5qxN2FVHA0qsaRghzkLDf=KZHEUN7rg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220825200600.GA1465148%40nathanxps13>
Precedence: bulk


--n8g4imXOkfNTN/H1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Aug 25, 2022 at 03:29:41PM +0200, talk to ben wrote:
> Here is a patch with the proposed wording.

Here is the same patch with a couple more links.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--n8g4imXOkfNTN/H1
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="v4-0001-basic_archive-parameter-visibility-doc-patch.patch"

From 92a6d8669d9e5b527a7ac9af7eb359a86526775b Mon Sep 17 00:00:00 2001
From: benoit <benoit.lobreau@dalibo.com>
Date: Mon, 22 Aug 2022 12:00:46 +0200
Subject: [PATCH v4 1/1] basic_archive parameter visibility doc patch

Module parameters are only visible from the pg_settings view once
the module is loaded. Since an archive module is loaded by the archiver
process, the parameters are never visible from the view. This patch
adds a note bout this in the pg_settings system view documentation.
---
 doc/src/sgml/system-views.sgml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/doc/src/sgml/system-views.sgml b/doc/src/sgml/system-views.sgml
index 44aa70a031..18ac4620f0 100644
--- a/doc/src/sgml/system-views.sgml
+++ b/doc/src/sgml/system-views.sgml
@@ -3275,7 +3275,15 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
 
   <para>
    This view does not display <link linkend="runtime-config-custom">customized options</link>
-   until the extension module that defines them has been loaded.
+   until the extension module that defines them has been loaded by the backend
+   process executing the query (e.g., via
+   <xref linkend="guc-shared-preload-libraries"/>, the
+   <link linkend="sql-load"><command>LOAD</command></link> command, or a call
+   to a <link linkend="xfunc-c">user-defined C function</link>).  For example,
+   since the <xref linkend="guc-archive-library"/> is only loaded by the
+   archiver process, this view will not display any customized options defined
+   by <link linkend="archive-modules">archive modules</link> unless special
+   action is taken to load them into the backend process executing the query.
   </para>
 
   <para>
-- 
2.25.1


--n8g4imXOkfNTN/H1--