Feedback-ID: id4a34324:Fastmail
Date: Thu, 25 Aug 2022 20:29:43 -0700
From: Andres Freund <andres@anarazel.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Niyas Sait <niyas.sait@linaro.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <20220826032943.nwoepbegzwntbmks@awork3.anarazel.de>
References: 
 <CAFPTBD_+n3C_rrt9Y5mytaw0GJX+SAywMCgKfEpRxpLvzeSMrA@mail.gmail.com>
 <Yl9TmT/Jmz7i2umV@paquier.xyz>
 <CAFPTBD9qPsFMN_Y0HwR+2uRtQGfVnQRa-mxUnAu-MhyEnf8JHA@mail.gmail.com>
 <YmDYdiKlYP0D57ZH@paquier.xyz>
 <CAFPTBD8Mk0X3h0UhWDbN7dLf1-eFeqcE8Qe3SUKzH9b+Gj1kBg@mail.gmail.com>
 <YmX2nJyeykpODEsB@paquier.xyz>
 <CAFPTBD-+YT0wZTh_KJHK+G_DfA9+Y6FrkACkCFz8d4+BZjacuQ@mail.gmail.com>
 <Ynm5g2152/yKc/0o@paquier.xyz>
 <20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de>
 <YwgrZcEUh6pgLg+u@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YwgrZcEUh6pgLg+u@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20220826032943.nwoepbegzwntbmks%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-08-26 11:09:41 +0900, Michael Paquier wrote:
> On Thu, Aug 25, 2022 at 06:29:07PM -0700, Andres Freund wrote:
> > I accidentally did a lot of testing with DYNAMICBASE - I accidentally
> > mistranslated MSBuildProject.pm's <RandomizedBaseAddress>false</> to adding
> > /DYNAMICBASE in the meson port. Survived several hundred CI cycles and dozens
> > of local runs without observing any problems related to that.
> > 
> > Which doesn't surprise me, given the way we reserve space in the new process.
> 
> Still, we had problems with that in the past and I don't recall huge
> changes in the way we allocate shmem on WIN32.

It's really not great that 7f3e17b4827 disabled randomization without even a
comment as to why...

There actually seems to have been a lot of work in that area. See 617dc6d299c
/ bcbf2346d69 and as well as the retrying in 45e004fb4e39. Those weren't
prevented by us disabling ASLR.

Greetings,

Andres Freund