Feedback-ID: id4a34324:Fastmail
Date: Sun, 28 Aug 2022 08:41:54 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
	Niyas Sait <niyas.sait@linaro.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <20220828154154.4vk6lymdbvx7hnhc@awork3.anarazel.de>
References: <YmX2nJyeykpODEsB@paquier.xyz>
 <CAFPTBD-+YT0wZTh_KJHK+G_DfA9+Y6FrkACkCFz8d4+BZjacuQ@mail.gmail.com>
 <Ynm5g2152/yKc/0o@paquier.xyz>
 <20220826012907.gjw3jdqdgsts5y65@awork3.anarazel.de>
 <YwgrZcEUh6pgLg+u@paquier.xyz>
 <20220826032943.nwoepbegzwntbmks@awork3.anarazel.de>
 <YwmCj/VGXjCeNcrh@paquier.xyz>
 <20220827192757.akupv6cydlgksd2y@awork3.anarazel.de>
 <YwsX3Jf89ucT/VFC@paquier.xyz>
 <2655387.1661695793@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2655387.1661695793@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220828154154.4vk6lymdbvx7hnhc%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-08-28 10:09:53 -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > True enough.  I have applied the patch to re-enable that on HEAD.
> > Let's now see what happens in the next couple of days.  Popcorn is
> > ready here.
>
> Hmm:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2022-08-28%2010%3A30%3A29
>
> Maybe that's just unrelated noise, but it sure looks weird: after
> passing the core regression tests in "make check", it failed in
> pg_upgrade's run with
>
> diff -w -U3 H:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/xml.out H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_upgrade/tmp_check/results/xml.out
> --- H:/prog/bf/root/HEAD/pgsql.build/src/test/regress/expected/xml.out	Wed May 18 18:30:12 2022
> +++ H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_upgrade/tmp_check/results/xml.out	Sun Aug 28 06:55:14 2022
> @@ -1557,7 +1557,7 @@
>  \\x
>  SELECT * FROM XMLTABLE('*' PASSING '<e>pre<!--c1--><?pi arg?><![CDATA[&ent1]]><n2>&amp;deep</n2>post</e>' COLUMNS x xml PATH 'node()', y xml PATH '/');
>  -[ RECORD 1 ]-----------------------------------------------------------
> -x | pre<!--c1--><?pi arg?><![CDATA[&ent1]]><n2>&amp;deep</n2>post
> +x | pre<?pi arg?><![CDATA[&ent1]]><!--c1--><n2>&amp;deep</n2>post
>  y | <e>pre<!--c1--><?pi arg?><![CDATA[&ent1]]><n2>&amp;deep</n2>post</e>+
>    |

Pretty weird, agreed. But hard to see how it could be caused by the
randomization change, except that perhaps it could highlight a preexisting
bug?

Greetings,

Andres Freund