Date: Sun, 28 Aug 2022 12:08:07 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	samay sharma <smilingsamay@gmail.com>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: [RFC] building postgres with meson - v12
Message-ID: <20220828170806.GN2342@telsasoft.com>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220827180447.zbmfk6sp2af4ntio@awork3.anarazel.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20220828170806.GN2342%40telsasoft.com>
Precedence: bulk

with_temp_install is repeated twice in prove_check:

> Subject: [PATCH v12 02/15] Split TESTDIR into TESTLOGDIR and TESTDATADIR         
> 
> -   TESTDIR='$(CURDIR)/tmp_check' $(with_temp_install)
>     PGPORT='6$(DEF_PGPORT)' \
> +   TESTLOGDIR='$(CURDIR)/tmp_check/log' $(with_temp_install) \
> +   TESTDATADIR='$(CURDIR)/tmp_check' $(with_temp_install) \
> +   PGPORT='6$(DEF_PGPORT)' \

Before running an individual test like "meson test recovery/017_shm",
it's currently necessary to first manually run "meson test tmp_install".
Is it possible to make that happen automatically ?

You're running tap tests via a python script.  There's no problem with
that, but it's different from what's done by the existing makefiles.
I was able to remove the python indirection - maybe that's better to
talk about on the CI thread?  That moves some setup for TAP tests
(TESTDIR, PATH, cd) from Makefile into the existing perl, which means
less duplication.