Date: Mon, 29 Aug 2022 10:17:12 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: use ARM intrinsics in pg_lfind32() where available
Message-ID: <20220829171712.GA509233@nathanxps13>
References: <20220826182403.GA1917683@nathanxps13>
 <CAFBsxsF=K1Vo4fZELJMCSF8GGbcrC_FnkMt3sQcBZt=MExmjPA@mail.gmail.com>
 <20220827221234.GA15951@nathanxps13>
 <CA+hUKGLcDi5L-+QXXDTEEEd0ynYse7Fd6dXdP6W9e+XVpa-i4Q@mail.gmail.com>
 <20220827230049.GA111000@nathanxps13>
 <20220828035839.GA211073@nathanxps13>
 <CAFBsxsEyR9JkfbPcDXBRYEfdfC__OkwVGdwEAgY4Rv0cvw35EA@mail.gmail.com>
 <CAFBsxsEouaTwbmpqV+EW2=wFbhw2vHRe26NQTRcd0=NaOFDy7A@mail.gmail.com>
 <CAFBsxsFLBzf=0g-E6doX1dkVN81YBGS+9ff-1=r-eMriN3HGxA@mail.gmail.com>
 <CAFBsxsHoJUgXfSYuuhuasTDCw85DtrKx=Wga8j7y5+sPMOam6g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="FL5UXtIhxfXey3p5"
Content-Disposition: inline
In-Reply-To: 
 <CAFBsxsHoJUgXfSYuuhuasTDCw85DtrKx=Wga8j7y5+sPMOam6g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20220829171712.GA509233%40nathanxps13>
Precedence: bulk


--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 29, 2022 at 05:49:46PM +0700, John Naylor wrote:
> Bowerbird just reported the same error, so I went ahead and pushed a
> fix with this.

Thanks!  I've attached a follow-up patch with a couple of small
suggestions.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

--FL5UXtIhxfXey3p5
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="nitpicks.patch"

diff --git a/src/include/port/simd.h b/src/include/port/simd.h
index 0ff1549083..745890f77f 100644
--- a/src/include/port/simd.h
+++ b/src/include/port/simd.h
@@ -77,6 +77,9 @@ static inline bool vector8_has(const Vector8 v, const uint8 c);
 static inline bool vector8_has_zero(const Vector8 v);
 static inline bool vector8_has_le(const Vector8 v, const uint8 c);
 static inline bool vector8_is_highbit_set(const Vector8 v);
+#ifndef USE_NO_SIMD
+static inline bool vector32_is_highbit_set(const Vector32 v);
+#endif
 
 /* arithmetic operations */
 static inline Vector8 vector8_or(const Vector8 v1, const Vector8 v2);
@@ -88,7 +91,7 @@ static inline Vector8 vector8_ssub(const Vector8 v1, const Vector8 v2);
 /*
  * comparisons between vectors
  *
- * Note: These return a vector rather than booloan, which is why we don't
+ * Note: These return a vector rather than boolean, which is why we don't
  * have non-SIMD implementations.
  */
 #ifndef USE_NO_SIMD

--FL5UXtIhxfXey3p5--