public inbox for [email protected]  
help / color / mirror / Atom feed
From: Nathan Bossart <[email protected]>
To: Robert Haas <[email protected]>
Cc: tushar <[email protected]>
Cc: Joe Conway <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Bossart, Nathan <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: replacing role-level NOINHERIT with a grant-level option
Date: Mon, 29 Aug 2022 15:04:19 -0700
Message-ID: <20220829220419.GA539509@nathanxps13> (raw)
In-Reply-To: <CA+TgmoZSU1h6hU4u_T_fMbefEaKWyaWjreubuyGeR057dPnLkg@mail.gmail.com>
References: <[email protected]>
	<CA+Tgmob6pVopLZ+NJuy_AxDS0uvgHhjjEBYQTBZXek-vM9dmGw@mail.gmail.com>
	<[email protected]>
	<CA+TgmobWFL5eU=60egYuzL0C0cgaVFEOVriTk_Rbs_cpj=MreQ@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYkbcH=njVN-vbRDorj9VqTGNzGHCYizO_5k1RWxGOQfQ@mail.gmail.com>
	<CA+TgmoaKMnde2W_=u7CqeCKi=FKnfbNQPwOR=c_3c8qD7b2nhQ@mail.gmail.com>
	<20220828211421.GA213902@nathanxps13>
	<CA+TgmobWjtFEsZ0vfNoCJVipB6WVc5BUPYq9m8eEE-4zMkgzug@mail.gmail.com>
	<CA+TgmoZSU1h6hU4u_T_fMbefEaKWyaWjreubuyGeR057dPnLkg@mail.gmail.com>

On Mon, Aug 29, 2022 at 03:38:57PM -0400, Robert Haas wrote:
> Here is a patch to rearrange the logic slightly and also add a test
> case memorializing the intended behavior. Without this change, the
> regression test included in the patch fails like this:
> 
> ERROR:  no possible grantors
> 
> ...which is never supposed to happen.

The grantor column in the expected test output refers to "rhaas", so I
imagine the test only passes on your machines.  Should we create a new
grantor role for this test?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (66+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: replacing role-level NOINHERIT with a grant-level option
  In-Reply-To: <20220829220419.GA539509@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox