Feedback-ID: id4a34324:Fastmail
Date: Mon, 29 Aug 2022 17:33:56 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
	Niyas Sait <niyas.sait@linaro.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <20220830003356.yl7ok3elemonrclo@awork3.anarazel.de>
References: <20220826032943.nwoepbegzwntbmks@awork3.anarazel.de>
 <YwmCj/VGXjCeNcrh@paquier.xyz>
 <20220827192757.akupv6cydlgksd2y@awork3.anarazel.de>
 <YwsX3Jf89ucT/VFC@paquier.xyz>
 <2655387.1661695793@sss.pgh.pa.us>
 <20220828154154.4vk6lymdbvx7hnhc@awork3.anarazel.de>
 <2679975.1661701879@sss.pgh.pa.us>
 <YwwSdACDiHqtPkMA@paquier.xyz>
 <Yw1QVptf33FMZw6n@paquier.xyz>
 <3426682.1661817511@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3426682.1661817511@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20220830003356.yl7ok3elemonrclo%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-08-29 19:58:31 -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > This is amazing.  The issue has showed up a second time in a row in
> > bowerbird, as of:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2022-08-29%2013%3A30%3A32
> 
> That is fascinating.

> > I don't know what to think about ASLR that manipulates the comment in
> > this XML object under VS 2017 (perhaps a compiler issue?), but it
> > should be possible to go back to green simply by removing "<!--c1-->"
> > from the input string.  Creating an extra output pattern here would be
> > very costly, as xml_2.out and xml.out have outputs for --with-libxml.
> 
> > Would people object if I do that for now?
> 
> Let's let it go for a few more runs.  I want to know whether it
> reproduces 100% or only sometimes.

The weirdest part is that it only happens as part of the the pg_upgrade test.

I just tested it in my test windows vm (win 10, vs 2019), with a build of
libxml I had around (2.9.7), and the regression tests passed both "normally"
and within pg_upgrade.

Greetings,

Andres Freund